Date: Wed, 14 Sep 2005 20:12:33 +0300 From: Jonathan <afarsec@012.net.il> To: FreeBSD-gnats-submit@FreeBSD.org Cc: mike@infonexus.com, scheidell@secnap.com Subject: ports/86132: Dependancy fixes for security/firewalk Message-ID: <0IMT0024AHCMU6C0@i_mtaout3.012.net.il> Resent-Message-ID: <200509141720.j8EHKGIK056497@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 86132 >Category: ports >Synopsis: Dependancy fixes for security/firewalk >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Wed Sep 14 17:20:15 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Jonathan >Release: FreeBSD 6.0-BETA4 i386 >Organization: Looking for one. >Environment: System: FreeBSD hasta.siempre.com 6.0-BETA4 FreeBSD 6.0-BETA4 #4: Fri Sep 9 00:07:43 IDT 2005 root@an.dan.te.com:/usr/obj/usr/src/sys/GENERIC i386 >Description: Michael Scheidell found and fixed two issues with libnet dependancies: 1. Firewalk port really depends on net/libnet-devel, but the check can be satisfied by net/libnet. 2. BIOCIMMEDIATE is undefined in some cases. The first problem is fixed by depending on an include file that is present only in net/libnet-devel. I couldn't reproduce the second problem, but the fix seems harmless so I'm including it. Comitter, don't forget to add Michael Scheidell scheidell<at>secnap.com to the "Additional FreeBSD Contributors" of the "FreeBSD Contributors" article. Thanks, Michael. >How-To-Repeat: Install net/libnet. Install security/firewalk Observe. >Fix: --- firewalk.diff begins here --- diff -urN firewalk.orig/Makefile firewalk/Makefile --- firewalk.orig/Makefile Mon Nov 15 00:26:10 2004 +++ firewalk/Makefile Wed Sep 14 19:22:07 2005 @@ -16,7 +16,7 @@ COMMENT= A remote firewall auditing tool BUILD_DEPENDS= ${LOCALBASE}/lib/libdnet.a:${PORTSDIR}/net/libdnet \ - ${LOCALBASE}/lib/libnet.a:${PORTSDIR}/net/libnet-devel + ${LOCALBASE}/include/libnet/libnet-types.h:${PORTSDIR}/net/libnet-devel RUN_DEPENDS= ${BUILD_DEPENDS} WRKSRC= ${WRKDIR}/Firewalk diff -urN firewalk.orig/files/patch-include:firewalk.h firewalk/files/patch-include:firewalk.h --- firewalk.orig/files/patch-include:firewalk.h Thu Jan 1 02:00:00 1970 +++ firewalk/files/patch-include:firewalk.h Wed Sep 14 19:21:19 2005 @@ -0,0 +1,13 @@ +--- include/firewalk.h.orig Wed Sep 14 19:19:27 2005 ++++ include/firewalk.h Wed Sep 14 19:20:37 2005 +@@ -41,6 +41,10 @@ + #include <dnet.h> + #include <libnet.h> + ++#ifndef BIOCIMMEDIATE ++#define BIOCIMMEDIATE _IOW('B',112,u_int) ++#endif ++ + #define FW_BANNER "Firewalk (c) 2002 Mike D. Schiffman \ + <mike@infonexus.com>\nhttp://www.packetfactory.net/firewalk\n\ + for more information.\n" --- firewalk.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0IMT0024AHCMU6C0>