From owner-freebsd-audit  Sat Aug 24 22:26:19 2002
Delivered-To: freebsd-audit@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2152F37B400; Sat, 24 Aug 2002 22:26:18 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 055C343E4A; Sat, 24 Aug 2002 22:26:17 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id FAA31782;
	Sun, 25 Aug 2002 05:26:15 GMT
Date: Sun, 25 Aug 2002 15:32:05 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Giorgos Keramidas <keramida@FreeBSD.ORG>
Cc: audit@FreeBSD.ORG
Subject: Re: a bin/ls warning with WARNS=5
In-Reply-To: <20020823062636.GA10607@hades.hell.gr>
Message-ID: <20020825152915.K14326-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On Fri, 23 Aug 2002, Giorgos Keramidas wrote:

> On 2002-08-23 08:47 +0000, Giorgos Keramidas <keramida@FreeBSD.ORG> wrote:
> > WFORMAT=0 remains since I don't know how to fix the format warning :-/
>
> A better fix for the WFORMAT case would probably be:
>
> %%%
> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/src/bin/ls/Makefile,v
> retrieving revision 1.23
> diff -u -r1.23 Makefile
> --- Makefile	4 Feb 2002 03:06:50 -0000	1.23
> +++ Makefile	23 Aug 2002 06:20:03 -0000
> @@ -3,8 +3,9 @@
>
>  PROG=	ls
>  SRCS=	cmp.c lomac.c ls.c print.c util.c
> -NO_WERROR=1
> -WFORMAT=0
> +WARNS?=	5
> +WFORMAT=1
> +CWARNFLAGS=	-Wno-format-nonliteral
>  DPADD=	${LIBM}
>  LDADD=	-lm
>
> %%%

No; this adds a hard-coded dependency on gcc.  Maybe WFORMAT=0.5 should
give half-baked format checking.  The value for half-bakedness would at
least easier to remember than what WARNS=5 means today ;-).

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message