From owner-cvs-all Sat Apr 20 8: 2:45 2002 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id B025237B41B; Sat, 20 Apr 2002 08:02:38 -0700 (PDT) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.6) with SMTP id g3KF2Bw86193; Sat, 20 Apr 2002 11:02:11 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Sat, 20 Apr 2002 11:02:10 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: "Andrey A. Chernov" Cc: "Jacques A. Vidrine" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh servconf.c session.c In-Reply-To: <20020420145437.GB5350@nagual.pp.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 20 Apr 2002, Andrey A. Chernov wrote: > > Yeah, personally I'd prefer we avoid introducing gratuitous diffs against > > the OpenSSH source -- some changes are necessary (PAM, et al), but > > anything beyond the base necessary changes just makes updating more of a > > pain. We've already had updates stalled by >6-8 months because of many > > local changes, so that's a problem we need to be very careful to avoid. > > Please note that "CheckMail" was in OpenSSH since long time and was > removed just recently, making lack of "login" look & feel without any > reason. Moreover, old "ssh" (pre-OpenSSH) check mail too without any > option, like "login" does. > > Users really want to know they have new mail when they logged in! > > About setusercontext() changes: they are absolutely necessary, if we > support login.conf. We can either remove them with whole login.conf > support (why we have login.conf so?) or do it correctly. We can't live > with half-singing half-dancing old variant, I mean broken login.conf > support. Note that I wasn't necessarily making the judgement that your changes were gratuitous, just cautioning against gratuitous changes. :-) Having correct functioning of user context is a very good thing, and something where there have been bugs previously (I haven't had a chance to do tests to make sure they didn't recur with the recent upgrades, and need to do that actually). On the other hand, we need to find a good balance between local changes and merged ones -- I know that there have been some problems getting stuff merged back into the base distribution in the past, but for legitimate bug/feature fixes, it's important we make the effort. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message