Date: Sat, 7 Mar 2009 07:47:29 GMT From: "Scot W. Hetzel" <swhetzel@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/132382: [patch] databases/sqlite3: Change hard coded TCL dependancy to USE_TCL Message-ID: <200903070747.n277lTY8017038@www.freebsd.org> Resent-Message-ID: <200903070750.n277o65n002776@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 132382
>Category: ports
>Synopsis: [patch] databases/sqlite3: Change hard coded TCL dependancy to USE_TCL
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 07 07:50:05 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Scot W. Hetzel
>Release: 8.0-CURRENT
>Organization:
>Environment:
FreeBSD hp010 8.0-CURRENT FreeBSD 8.0-CURRENT #1: Fri Mar 6 02:22:28 CST 2009 root@hp010:/usr/obj/usr/src/8x-zfs/sys/DV8135NR amd64
>Description:
Currently, databases/sqlite3 has a dependency on TCL 8.4. The port uses an inconsistent variable (TCL_V) to select a different version of TCL.
This will cause all dependant ports on sqlite3 to have an indirect dependency on TCL 8.4 (or ${TCL_V}).
>How-To-Repeat:
Install TCL > 8.4 and set WITH_TCL_VER to that version
Then install databases/sqlite3
This will cause the installation to TCL 8.4
>Fix:
The attached patch allows databases/sqlite3 to choose the TCL version through the USE_TCL variable.
Patch attached with submission follows:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/databases/sqlite3/Makefile,v
retrieving revision 1.34
diff -u -r1.34 Makefile
--- Makefile 27 Jan 2009 02:16:09 -0000 1.34
+++ Makefile 7 Mar 2009 05:07:36 -0000
@@ -46,12 +46,12 @@
.endif
.if defined(WITH_TCLWRAPPER)
-TCL_V?= 8.4
-MAKE_ARGS+= TCLSH=tclsh${TCL_V}
-MAKE_ENV+= TCL_VER=${TCL_V}
+USE_TCL= 84+
+.include "${PORTSDIR}/Mk/bsd.tcl.mk"
+MAKE_ARGS+= TCLSH=${TCLSH}
+MAKE_ENV+= TCL_VER=${TCL_VER}
CATEGORIES+= lang tcl
-LIB_DEPENDS+= tcl${TCL_V:S/.//}:${PORTSDIR}/lang/tcl${TCL_V:S/.//}
-CONFIGURE_ARGS+= --with-tcl=${LOCALBASE}/lib/tcl${TCL_V}
+CONFIGURE_ARGS+= --with-tcl=${TCL_LIBDIR}
PLIST_SUB+= WITH_TCLWRAPPER=""
.else
CONFIGURE_ARGS+= --disable-tcl
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903070747.n277lTY8017038>