From owner-freebsd-current  Mon Aug 12 12:29:56 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 845F137B400
	for <freebsd-current@FreeBSD.ORG>; Mon, 12 Aug 2002 12:29:54 -0700 (PDT)
Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 11AC743E42
	for <freebsd-current@FreeBSD.ORG>; Mon, 12 Aug 2002 12:29:54 -0700 (PDT)
	(envelope-from obrien@NUXI.com)
Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1])
	by dragon.nuxi.com (8.12.5/8.12.2) with ESMTP id g7CJTo8A080464;
	Mon, 12 Aug 2002 12:29:50 -0700 (PDT)
	(envelope-from obrien@dragon.nuxi.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.12.5/8.12.5/Submit) id g7CJTnVm080463;
	Mon, 12 Aug 2002 12:29:49 -0700 (PDT)
Date: Mon, 12 Aug 2002 12:29:49 -0700
From: "David O'Brien" <obrien@FreeBSD.ORG>
To: "Andrey A. Chernov" <ache@nagual.pp.ru>
Cc: Bruce Evans <bde@zeta.org.au>,
	Terry Lambert <tlambert2@mindspring.com>,
	David Xu <bsddiy@yahoo.com>, Julian Elischer <julian@elischer.org>,
	FreeBSD CURRENT <freebsd-current@FreeBSD.ORG>
Subject: Re: cvs commit: src/sys/kern kern_sig.c (fwd)
Message-ID: <20020812192949.GB4787@dragon.nuxi.com>
Reply-To: obrien@FreeBSD.ORG
References: <20020812113101.GA2089@nagual.pp.ru> <20020813031235.O25510-100000@gamplex.bde.org> <20020812172131.GA2139@nagual.pp.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020812172131.GA2139@nagual.pp.ru>
User-Agent: Mutt/1.4i
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD Group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Mon, Aug 12, 2002 at 09:21:31PM +0400, Andrey A. Chernov wrote:
> On Tue, Aug 13, 2002 at 03:15:02 +1000, Bruce Evans wrote:
> > 
> > Anyway, it has one blatant style bug (not 1TBS) and no explanation of
> > the bug, so it should not have been committed verbatim.  See another
> > reply for an analysis of the patch.
> 
> According to commit guide, explanations are not commited, only what is
> changed. For explanation (terminal group mismatch) read whole thread,
> especially David's analysis.

Wrong Andrey.  For hairy code, there should be comments -- especially if
one must realize someone obtuse to understand how the code works.  6mo.
from now no one will be able to find the explanation in a mailing list.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message