From owner-freebsd-current Mon Mar 17 9:10:42 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 35FE437B401 for ; Mon, 17 Mar 2003 09:10:41 -0800 (PST) Received: from pimout4-ext.prodigy.net (pimout4-ext.prodigy.net [207.115.63.103]) by mx1.FreeBSD.org (Postfix) with ESMTP id 390D043F75 for ; Mon, 17 Mar 2003 09:10:40 -0800 (PST) (envelope-from wa1ter@myrealbox.com) Received: from myrealbox.com (adsl-67-119-36-59.dsl.lsan03.pacbell.net [67.119.36.59]) by pimout4-ext.prodigy.net (8.12.3 patch/8.12.3) with ESMTP id h2HHAcWE543410 for ; Mon, 17 Mar 2003 12:10:39 -0500 Message-ID: <3E76018F.5030406@myrealbox.com> Date: Mon, 17 Mar 2003 09:10:39 -0800 From: walt Organization: none User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3b) Gecko/20030213 X-Accept-Language: en-us, en MIME-Version: 1.0 To: freebsd-current@freebsd.org Subject: Re: Why did INVARIANTS hide the geom bug? References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Poul-Henning Kamp wrote: > In message <3E74BEA3.6070603@myrealbox.com>, walt writes: > >>If inclusion of INVARIANTS serves to disguise bugs in >>the kernel, I wonder if kernel committers should be >>using this option routinely? > > > Please check into our current reality :-) Hm. How do I parse that sentence? If you are implying (as it says in NOTES) that INVARIANTS are "not enabled by default" then my question is certainly a stupid one. However, when I look at the GENERIC kernel config file I see options INVARIANTS options INVARIANT_SUPPORT so what am I to think? Do most kernel committers run a GENERIC kernel as the FBSD website says? Does anyone take a poll occasionally? Did I miss your point entirely? > Suggest you check what INVARIANTS actually do. Looking at the code thru my amateur eyes it appears that defining INVARIANTS allows the programmer to add whatever code he wishes with an ifdef statement. That covers a lot of territory. Looking thru sys/geom I don't see any such ifdefs in your code, so I still don't know why the recent geom bug was hidden by INVARIANTS. Hope you're feeling better :-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message