From owner-freebsd-ports@freebsd.org Sat Apr 24 10:02:23 2021 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 50FB05F92A6 for ; Sat, 24 Apr 2021 10:02:23 +0000 (UTC) (envelope-from njm@njm.me.uk) Received: from smtp002.apm-internet.net (smtp002.apm-internet.net [85.119.248.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FS6CK6wDqz4lC4 for ; Sat, 24 Apr 2021 10:02:21 +0000 (UTC) (envelope-from njm@njm.me.uk) Received: (qmail 814 invoked from network); 24 Apr 2021 10:02:19 -0000 X-APM-Out-ID: 16192585380081 X-APM-Authkey: 18389/1(18389/1) 1 Received: from unknown (HELO meld.njm.me.uk) (86.179.69.31) by smtp002.apm-internet.net with SMTP; 24 Apr 2021 10:02:19 -0000 Received: from triton.njm.me.uk (triton.njm.me.uk [192.168.144.133]) by meld.njm.me.uk (8.16.1/8.16.1) with ESMTPS id 13OA2DBw079075 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 24 Apr 2021 11:02:18 +0100 (BST) (envelope-from njm@njm.me.uk) Received: from localhost (localhost [127.0.0.1]) by triton.njm.me.uk (8.16.1/8.16.1) with ESMTP id 13OA2CDP077989 for ; Sat, 24 Apr 2021 11:02:12 +0100 (BST) (envelope-from njm@njm.me.uk) Date: Sat, 24 Apr 2021 11:02:12 +0100 From: "N.J. Mann" To: freebsd-ports@freebsd.org Subject: Problems with gitup - doesn't delete files / old ports. Message-ID: <2B71581BA1C1C9DBE6F3CDF3@triton.njm.me.uk> X-Mailer: Mulberry/4.0.8 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Rspamd-Queue-Id: 4FS6CK6wDqz4lC4 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of njm@njm.me.uk has no SPF policy when checking 85.119.248.221) smtp.mailfrom=njm@njm.me.uk X-Spamd-Result: default: False [-2.20 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[85.119.248.221:from]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[85.119.248.221:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[njm.me.uk]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:35259, ipnet:85.119.248.0/21, country:GB]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[freebsd-ports]; RCVD_IN_DNSWL_LOW(-0.10)[85.119.248.221:from] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Apr 2021 10:02:23 -0000 Hi, I have been using gitup for just over a week (and before that svn and before that cvsup) to update a local ports tree. I have encountered some annoying failures. I run it from a simple home made script called from cron at just after 10am local time everyday. The script basically does gitup ports >$HOME/var/log/gitup/ports.log 2>&1 gitup_res=$? and echo's the result code if non-zero. I seem to be always getting 1. Checking the logs gitup appears to be having issues with removing files and even removing deleted ports. This morning it choked on textproc/bsdsort: gitup: prune_tree: cannot remove /remote/ports/textproc/bsdsort/files: Directory not empty And, indeed that directory isn't empty: % ls -lRTtr /remote/ports/textproc/bsdsort total 4 -rw-r--r-- 1 njm wheel 915 15 Apr 14:45:35 2021 Makefile -rw-r--r-- 1 njm wheel 133 15 Apr 14:45:35 2021 distinfo drwxr-xr-x 2 njm wheel 4 15 Apr 14:45:35 2021 files -rw-r--r-- 1 njm wheel 368 15 Apr 14:45:35 2021 pkg-descr /remote/ports/textproc/bsdsort/files: total 3 -rw-r--r-- 1 njm wheel 516 15 Apr 14:45:35 2021 patch-sort.c -rw-r--r-- 1 njm wheel 221 15 Apr 14:45:35 2021 patch-vsort.h % I checked the handy web interface https://cgit.freebsd.org/ports/commit/textproc?id=b54974bf33c767167f058350819fa7b9c3142f02 and found that this port was removed a few days ago - above URL. Yesterday, I was trying to update firefox-esr when that failed building www/node. From the portmaster log: ===> Patching for node-16.0.0 ===> Applying FreeBSD patches for node-16.0.0 from /remote/ports/www/node/files Ignoring previously applied (or reversed) patch. 2 out of 2 hunks ignored--saving rejects to deps/v8/src/objects/js-list-format.cc.rej ===> FAILED Applying FreeBSD patch-deps_v8_src_objects_js-list-format.cc ===> Cleanly applied FreeBSD patch(es) patch-deps_openssl_config_archs_linux-elf_no-asm_openssl-cl.gypi patch-deps_openssl_config_archs_linux-elf_no-asm_openssl.gypi patch-deps_openssl_openssl-cl__no__asm.gypi patch-deps_openssl_openssl__no__asm.gypi patch-deps_v8_src_base_platform_platform-freebsd.cc patch-deps_v8_src_codegen_ppc_constants-ppc.h patch-deps_v8_src_libsampler_sampler.cc ===> FAILED to apply cleanly FreeBSD patch(es) patch-deps_v8_src_objects_js-list-format.cc *** Error code 1 Stop. make[1]: stopped in /remote/ports/www/node *** Error code 1 Stop. make: stopped in /remote/ports/www/node Again checking the friendly web interface I found https://cgit.freebsd.org/ports/commit/www/node?id=bc3d0937d0d2cc4a2e80334f5391a2d87458943e that said patch file had been removed four days ago. So, for me at least, gitup is not reliably removing deleted files and even deleted ports. Suggestions, recommendations, patches all welcome. Regards, Nick. --