From owner-freebsd-audit  Fri Jun 22  3:34:51 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [169.237.7.38])
	by hub.freebsd.org (Postfix) with ESMTP
	id D4ECA37B406; Fri, 22 Jun 2001 03:34:46 -0700 (PDT)
	(envelope-from obrien@nuxi.ucdavis.edu)
Received: from dragon.nuxi.com (root@trang.nuxi.com [206.40.252.115])
	by relay.nuxi.com (8.11.2/8.11.2) with ESMTP id f5MAYgR14306;
	Fri, 22 Jun 2001 03:34:42 -0700 (PDT)
	(envelope-from obrien@NUXI.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.11.3/8.11.1) id f5MAYfx00871;
	Fri, 22 Jun 2001 03:34:41 -0700 (PDT)
	(envelope-from obrien)
Date: Fri, 22 Jun 2001 03:34:41 -0700
From: "David O'Brien" <obrien@FreeBSD.ORG>
To: Dag-Erling Smorgrav <des@ofug.org>
Cc: Mike Barcroft <mike@q9media.com>,
	Alexey Zelkin <phantom@freebsd.org.ua>,
	Peter Pentchev <roam@orbitel.bg>, hackers@FreeBSD.ORG,
	audit@FreeBSD.ORG
Subject: Re: whois(1) patch for review
Message-ID: <20010622033441.A197@dragon.nuxi.com>
Reply-To: obrien@FreeBSD.ORG
References: <B757DEA3.D5A%mike@q9media.com> <xzpsngtcn1u.fsf@flood.ping.uio.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <xzpsngtcn1u.fsf@flood.ping.uio.no>; from des@ofug.org on Fri, Jun 22, 2001 at 03:37:17AM +0200
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On Fri, Jun 22, 2001 at 03:37:17AM +0200, Dag-Erling Smorgrav wrote:
> Mike Barcroft <mike@q9media.com> writes:
> > Arg..  I wish you had contacted me before doing this work.  From looking at
> > your patch, your using an old copy of my work.  The newest one is available
> > at: http://testbed.q9media.net/freebsd/whois.patch and will be committed
> > very-shortly-now(tm).
> 
> Since Mike's patch is a style cleanup with no functional impact except
> plugging a memory leak, I feel it's better to commit it first, and
> merge in Alexey's patch later, after it's been reviewed by this forum.

Uh wrong.  There were other non-style bits than just the memory leak.
For instance the cast changes are functionalty related, not style.
It should have been done in two commits.

-- 
-- David  (obrien@FreeBSD.org)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message