From nobody Sun Aug 24 03:51:31 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c8g2t21XKz65DtN; Sun, 24 Aug 2025 03:51:34 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta004.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c8g2s4mDqz3ZJR; Sun, 24 Aug 2025 03:51:33 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=permerror reason="p tag has invalid value: quarantine rua=mailto:p[ostmaster@cschubert.com" header.from=cschubert.com (policy=permerror); spf=pass (mx1.freebsd.org: domain of cy.schubert@cschubert.com designates 3.97.99.33 as permitted sender) smtp.mailfrom=cy.schubert@cschubert.com Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTPS id pwBXuNROU5Mqyq1lVuFxaE; Sun, 24 Aug 2025 03:51:33 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id q1lTuAO5rWbOaq1lUuGg6N; Sun, 24 Aug 2025 03:51:33 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=Q5lx4J2a c=1 sm=1 tr=0 ts=68aa8c45 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=2OwXVqhp2XgA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=T_YFPyFoAAAA:8 a=CjxXgO3LAAAA:8 a=WWVxPgZ06bBHUdOfH7oA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=fKaBkT6cBtmegwcwHIDe:22 Received: from slippy.cwsent.com (slippy.cwsent.com [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 3C7F6843; Sat, 23 Aug 2025 20:51:31 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (Postfix) with ESMTP id 269AB380; Sat, 23 Aug 2025 20:51:31 -0700 (PDT) Date: Sat, 23 Aug 2025 20:51:31 -0700 From: Cy Schubert To: ShengYi Hung Cc: Gordon Bergling , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1685192ea1fa - main - hkbd: remove erorr detection in KDSKBSTATE ioctl Message-ID: <20250823205131.6c44846c@slippy.cwsent.com> In-Reply-To: <20250823203726.55c5a5ec@slippy.cwsent.com> References: <202508230450.57N4oxwG023161@gitrepo.freebsd.org> <20250823171011.BCFFF189@slippy.cwsent.com> <20250823203726.55c5a5ec@slippy.cwsent.com> Organization: KOMQUATS X-Mailer: Claws Mail 3.21.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfFTVXL4huLq8MXa4yCmYXMWaQQyCoXCQmzb3rrHyZ3ttkKXOBgWBiTXKWHqskrSrDBbVpIdvqRUjzULbZWCw+qQXnFONe/d0xPmQBFrQQ9t1Et24uUB5 THJ+tC3NXEf8eTSFFbPj8ZJo6KQM0EezpW3ji4wMe0g9WXRyGLsvzmY+SZfawa74W720T3GpSSOdn6IqvQWZkOjzsUacsRq0UX610BjyIsYN6zoyQR4HRAGC GoPoxqU7XcO6IUDlX8r3t1N8Nt9XhGrE0kzx+BLnQoYl6fyDlVpcEcQ7Dorh70DqO2aT3xg4h70I6YcuMGZ7n+byK4yWWlkOj+t6MUH8wO84xtq0LnLFTT2e 93DlMGZn X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.72 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_SHORT(-0.92)[-0.917]; RWL_MAILSPIKE_EXCELLENT(-0.40)[3.97.99.33:from]; R_SPF_ALLOW(-0.20)[+ip4:3.97.99.32/31]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[3.97.99.33:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; HAS_ORG_HEADER(0.00)[]; DMARC_BAD_POLICY(0.00)[cschubert.com : p tag has invalid value: quarantine rua=mailto:p[ostmaster@cschubert.com]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_DKIM_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4c8g2s4mDqz3ZJR On Sat, 23 Aug 2025 20:37:34 -0700 Cy Schubert wrote: > On Sat, 23 Aug 2025 13:27:23 -0400 > ShengYi Hung wrote: > > > Hello: > > > > I only submit two patches. What is the third patch you have mentioned? > > Is the one setting "sysctl usbhid=1"? > > > > On 8/23/25 13:10, Cy Schubert wrote: > > > In message , ShengYi Hung writes: > > >> Hello, thanks for the reminder. I compile the standalone module to test so > > >> didn't discover that. Fix it right now. > > >> Gordon Bergling writes: > > >> > > >> > > >>> Hi ShengYi, > > >>> > > >>> On Sat, Aug 23, 2025 at 04:50:59AM +0000, ShengYi Hung wrote: > > >>>> The branch main has been updated by aokblast: > > >>>> > > >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=1685192ea1faac28f2d4feede53e7 > > >> 0b6a380500f > > >>>> commit 1685192ea1faac28f2d4feede53e70b6a380500f > > >>>> Author: ShengYi Hung > > >>>> AuthorDate: 2025-08-21 17:59:15 +0000 > > >>>> Commit: ShengYi Hung > > >>>> CommitDate: 2025-08-23 04:50:09 +0000 > > >>>> > > >>>> hkbd: remove erorr detection in KDSKBSTATE ioctl > > >>>> > > >>>> The KDSKBSTATE ioctl brings the LED up. However, some keyboards (like > > >> qemu > > >>>> keyboard) may not have LED or failed to set the LED due to unexpected > > >> reason. > > >>>> Therefore, removing the error check as ukbd(4) does allow the keyboard > > >> works > > >>>> correctly with kbdcontrol(4). > > >>>> > > >>>> Also move hw.hid.hkbd.no_leds sysctl out of HID_BUG thus users can > > >>>> disable setting LEDs > > >>>> > > >>>> PR: 288968 > > >>>> Reviewed by: wulf > > >>>> Tested by: trashcan@ellael.org, marklmi26-fbsd@yahoo.com, trkelle > > >> rs@gmail.coom > > >>>> Approved by: lwsu (mentor), markj (mentor) > > >>>> MFC after 1 week > > >>>> Sponsored by: The FreeBSD Foundation > > >>>> Differential Revision: https://reviews.freebsd.org/D52101 > > >>>> > > >>>> mvalsmva > > >>>> --- > > >>> I am not sure how this is related, but since that commit, buildkernel of GE > > >> NERIC is broken both > > >>> on amd64 and aarch64. The following error is from an amd64 build, aarch64 i > > >> s the same. > > >>> ----------------------------- > > >>> /storage/freebsd/src/current/sys/dev/hid/hkbd.c:1831:10: error: called ob > > >> ject type 'char[5]' is not a function or function pointer > > >>> 1831 | DPRINTF(("error %d", error)); > > >>> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~ > > >>> /storage/freebsd/src/current/sys/dev/hid/hid.h:212:34: note: expanded fro > > >> m macro 'DPRINTF' > > >>> 212 | #define DPRINTF(...) DPRINTFN(1, __VA_ARGS__) > > >>> | ~~~~~~~~~~~~^~~~~~~~~~~~ > > >>> /storage/freebsd/src/current/sys/dev/hid/hid.h:208:17: note: expanded fro > > >> m macro 'DPRINTFN' > > >>> 208 | printf("%s: " fmt, \ > > >>> | ~~~~~~ ^ > > >>> 1 error generated. > > >>> --- hkbd.o --- > > >>> *** [hkbd.o] Error code 1 > > >>> ----------------------------- > > >>> > > >>> --Gordon > > >> -- > > >> Best Regards. > > >> ShengYi Hung. > > >> > > > My machines running X (laptops), > > > > > > - the right mouse key no longer works under X, I can no longer use X, > > > - the caps-lock light will not display under X > > > - on the text console works, X does not. > > > > > > The three commits related have bee reverted locally, functionality has > > > returned. > > > > > > > > Best Regards. > > > > ShengYi Hung. > > > > The hashes are, > > 1685192ea1fa > 8a847947153e > 6ea7e1f92882 > > I don't think 8a847947153e is related. 6ea7e1f92882 must be reverted in > order to revert 1685192ea1fa. > I reapplied the patches. The problem persisted. A clean kernel build also works around the problem. There is still a problem with the caps lock LED. It works on the console while under X it will not light until the first non-shift key is hit. I can live with that. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0