From owner-freebsd-current Wed Jun 19 05:30:30 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id FAA10630 for current-outgoing; Wed, 19 Jun 1996 05:30:30 -0700 (PDT) Received: from who.cdrom.com (who.cdrom.com [204.216.27.3]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id FAA10625 for ; Wed, 19 Jun 1996 05:30:28 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by who.cdrom.com (8.6.12/8.6.11) with ESMTP id FAA07060 for ; Wed, 19 Jun 1996 05:30:26 -0700 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.12/8.6.9) id WAA15182; Wed, 19 Jun 1996 22:23:46 +1000 Date: Wed, 19 Jun 1996 22:23:46 +1000 From: Bruce Evans Message-Id: <199606191223.WAA15182@godzilla.zeta.org.au> To: current@FreeBSD.org, nate@sri.MT.net Subject: Re: (Mis)feature of the current make macros Sender: owner-current@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk >I noticed this with the PC-CARD stuff, but if you have a man-page >definition, ../Makefile.inc gets included twice. Normally this isn't a >problem, but in the case where you set something with '+=' you'll end up >with it added to the variable twice. This was fixed in rev.1.5 of bsd.man.mk but I broke it again in rev.1.6. >Is there any Makefile that only includes ? If so, should >it? If not, we can remove the inclusion of ../Makefile.inc. I don't think so. We don't have a clear distinction between the primary and the secondary .mk files. The secondary ones certainly shouldn't include things that the primary ones have already included. Perhaps all .mk files should be idempotent and self-sufficient like all .h files should be. .if !defined(_foo_mk_) _foo_mk_= .include .endif !_foo_mk_ Is this the right style? .ifndef works but is never used in *.mk... Bruce