From owner-freebsd-net@FreeBSD.ORG Tue Mar 4 05:23:18 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DBC731065670 for ; Tue, 4 Mar 2008 05:23:18 +0000 (UTC) (envelope-from silby@silby.com) Received: from relay00.pair.com (relay00.pair.com [209.68.5.9]) by mx1.freebsd.org (Postfix) with SMTP id 80B928FC19 for ; Tue, 4 Mar 2008 05:23:18 +0000 (UTC) (envelope-from silby@silby.com) Received: (qmail 83297 invoked from network); 4 Mar 2008 05:23:16 -0000 Received: from unknown (HELO localhost) (unknown) by unknown with SMTP; 4 Mar 2008 05:23:16 -0000 X-pair-Authenticated: 209.68.2.70 Date: Mon, 3 Mar 2008 23:23:16 -0600 (CST) From: Mike Silbersack To: Fernando Gont In-Reply-To: <200803031412.m23EC4WB031100@venus.xmundo.net> Message-ID: <20080303231459.X43305@odysseus.silby.com> References: <200803030435.m234Z7As026508@venus.xmundo.net> <20080303001004.R37933@odysseus.silby.com> <200803031412.m23EC4WB031100@venus.xmundo.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Rui Paulo , freebsd-net@freebsd.org Subject: Re: Ephemeral ports patch (fixed) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Mar 2008 05:23:19 -0000 On Mon, 3 Mar 2008, Fernando Gont wrote: > At 04:11 a.m. 03/03/2008, Mike Silbersack wrote: > >>> Here's the same patch, but with the first ephemeral port changed from 1024 >>> to 10000. >> >> Now that I've actually gone to try to apply the patch (so I can view the >> two codepaths side by side, rather than in diff form), I'm finding that I >> can't apply it. I think all the whitespace got stomped, either by your >> mail program or my mail program. Can you please resent this as an >> attachment? > > Sure. Please let me know if this one is okay. > > Kind regards, > > -- > Fernando Gont > e-mail: fernando@gont.com.ar || fgont@acm.org > PGP Fingerprint: 7809 84F5 322E 45C7 F1C9 3945 96EE A9EF D076 FFF1 Too optimistic: ! #define IPPORT_EPHEMERALLAST 655535 Otherwise the patch looks good to me. It looked a bit strange in unified diff format, I needed to look at it in context format. (Strange, since I usually prefer unified.) Rui, were you going to get this committed? -Mike