From owner-cvs-all Sun Jul 23 6:30:11 2000 Delivered-To: cvs-all@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 2C8D537B78E; Sun, 23 Jul 2000 06:30:07 -0700 (PDT) (envelope-from bright@fw.wintelcom.net) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id e6NDU6P29216; Sun, 23 Jul 2000 06:30:06 -0700 (PDT) Date: Sun, 23 Jul 2000 06:30:06 -0700 From: Alfred Perlstein To: Mike Smith Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern imgact_elf.c Message-ID: <20000723063005.L13979@fw.wintelcom.net> References: <20000723005214.J13979@fw.wintelcom.net> <200007230811.BAA13280@mass.osd.bsdi.com> <20000723062802.K13979@fw.wintelcom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.4i In-Reply-To: <20000723062802.K13979@fw.wintelcom.net>; from bright@wintelcom.net on Sun, Jul 23, 2000 at 06:28:02AM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * Alfred Perlstein [000723 06:28] wrote: > * Mike Smith [000723 01:01] wrote: > > > I'm also concerned that you're using atomic_set_long() rather than > > > or'ing the flag in, there doesn't seem to be a flag in vnode.h that > > > could possibly co-exist with VTEXT but clearing all other flags > > > introduces an unexpected side-effect. > > > > Er, atomic_set_long is a bit-set operation. > > It's still overly paranoid. And yet another place where we've used bad function names to describe something. (would atomic_or_long have been so hard?) -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message