From owner-freebsd-java@FreeBSD.ORG  Tue May 15 17:48:53 2012
Return-Path: <owner-freebsd-java@FreeBSD.ORG>
Delivered-To: freebsd-java@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1F68D106564A;
	Tue, 15 May 2012 17:48:53 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
Received: from hammer.pct.niksun.com (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id ABB848FC08;
	Tue, 15 May 2012 17:48:52 +0000 (UTC)
Message-ID: <4FB29704.8080605@FreeBSD.org>
Date: Tue, 15 May 2012 13:48:52 -0400
From: Jung-uk Kim <jkim@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:12.0) Gecko/20120502 Thunderbird/12.0.1
MIME-Version: 1.0
To: Bryan Drewery <bryan@shatow.net>
References: <201205150540.q4F5e5Jb001282@freefall.freebsd.org>
In-Reply-To: <201205150540.q4F5e5Jb001282@freefall.freebsd.org>
X-Enigmail-Version: 1.5pre
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: glewis@FreeBSD.org, freebsd-java@freebsd.org
Subject: Re: ports/167903: [PATCH] java/openjdk6: Fix build failure in 8.3
 jail running on 9+ system
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 May 2012 17:48:53 -0000

On 2012-05-15 01:40:05 -0400, Bryan Drewery wrote:
> The following reply was made to PR ports/167903; it has been noted by GNATS.
> 
> From: Bryan Drewery <bryan@shatow.net>
> To: bug-followup@FreeBSD.org
> Cc:  
> Subject: Re: ports/167903: [PATCH] java/openjdk6: Fix build failure in 8.3
>  jail running on 9+ system
> Date: Tue, 15 May 2012 00:39:06 -0500
> 
>  This is a multi-part message in MIME format.
>  --------------060109060400070605040004
>  Content-Type: text/plain; charset=ISO-8859-1
>  Content-Transfer-Encoding: 7bit
>  
>  This should be LIB_DEPENDS+=. This patch is correct.
>  
>  Bryan
>  
>  --------------060109060400070605040004
>  Content-Type: text/plain; charset=windows-1252;
>   name="patch-openjdk16-compat7.txt"
>  Content-Transfer-Encoding: 7bit
>  Content-Disposition: attachment;
>   filename="patch-openjdk16-compat7.txt"
>  
>  --- Makefile.orig	2012-05-15 00:16:27.000000000 -0500
>  +++ Makefile	2012-05-15 00:34:09.000000000 -0500
>  @@ -78,6 +78,10 @@
>   
>   .include <bsd.port.pre.mk>
>   
>  +.if ${OSVERSION} >= 800105
>  +LIB_DEPENDS+=	z.4:${PORTSDIR}/misc/compat7x
>  +.endif
>  +
>   .if defined(WITH_IPV6)
>   CATEGORIES+=	ipv6
>   .endif

I don't think this patch is acceptable because it introduces unnecessary
dependency for "normal" case.

In fact, the patch in 138638 was incomplete and it had to add this:

--- diablo-jdk16/Makefile.orig	2012-05-15 13:19:41.000000000 -0400
+++ diablo-jdk16/Makefile	2012-05-15 13:42:23.000000000 -0400
@@ -44,7 +44,7 @@
 SUB_LIST+=	ARCH="${ARCH}" \
		JDK_VERSION="${JDK_VERSION}"

-PKG_IGNORE_DEPENDS=	'^[^x|^j]'
+PKG_IGNORE_DEPENDS=	'^[^c|^j|^x]'

 INSTALL_DIR=	${PREFIX}/${PKGNAMEPREFIX}jdk${JDK_VERSION}

After this change, we have:

# pkg_info -r diablo-jdk-1.6.0.07.02_19
Information for diablo-jdk-1.6.0.07.02_19:

Depends on:
Dependency: xproto-7.0.22
Dependency: xextproto-7.2.0
Dependency: compat7x-amd64-7.3.703000.201008_1
Dependency: javavmwrapper-2.3.5
Dependency: java-zoneinfo-2012.c

Jung-uk Kim