From owner-svn-src-all@FreeBSD.ORG Fri Feb 27 22:12:15 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 89B61106564A; Fri, 27 Feb 2009 22:12:15 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 7793C8FC16; Fri, 27 Feb 2009 22:12:15 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n1RMCF7c084760; Fri, 27 Feb 2009 22:12:15 GMT (envelope-from thompsa@svn.freebsd.org) Received: (from thompsa@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n1RMCFlG084758; Fri, 27 Feb 2009 22:12:15 GMT (envelope-from thompsa@svn.freebsd.org) Message-Id: <200902272212.n1RMCFlG084758@svn.freebsd.org> From: Andrew Thompson Date: Fri, 27 Feb 2009 22:12:15 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r189125 - head/sys/dev/usb X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2009 22:12:16 -0000 Author: thompsa Date: Fri Feb 27 22:12:15 2009 New Revision: 189125 URL: http://svn.freebsd.org/changeset/base/189125 Log: Change the last references to PRIV_ROOT. /dev/usb used to be world writable so further root checks were needed, this isnt the case anymore but just change it to PRIV_DRIVER until it can be investigated later. Spotted by: rwatson Modified: head/sys/dev/usb/usb_dev.c head/sys/dev/usb/usb_generic.c Modified: head/sys/dev/usb/usb_dev.c ============================================================================== --- head/sys/dev/usb/usb_dev.c Fri Feb 27 21:50:15 2009 (r189124) +++ head/sys/dev/usb/usb_dev.c Fri Feb 27 22:12:15 2009 (r189125) @@ -1466,7 +1466,7 @@ usb2_static_ioctl(struct cdev *dev, u_lo *(int *)data = usb2_template; break; case USB_SET_TEMPLATE: - err = priv_check(curthread, PRIV_ROOT); + err = priv_check(curthread, PRIV_DRIVER); if (err) break; usb2_template = *(int *)data; Modified: head/sys/dev/usb/usb_generic.c ============================================================================== --- head/sys/dev/usb/usb_generic.c Fri Feb 27 21:50:15 2009 (r189124) +++ head/sys/dev/usb/usb_generic.c Fri Feb 27 22:12:15 2009 (r189125) @@ -1685,7 +1685,7 @@ ugen_set_power_mode(struct usb2_fifo *f, (udev->parent_hub == NULL)) { return (EINVAL); } - err = priv_check(curthread, PRIV_ROOT); + err = priv_check(curthread, PRIV_DRIVER); if (err) return (err); @@ -1766,7 +1766,7 @@ ugen_do_port_feature(struct usb2_fifo *f struct usb2_hub *hub; int err; - err = priv_check(curthread, PRIV_ROOT); + err = priv_check(curthread, PRIV_DRIVER); if (err) { return (err); }