From owner-svn-src-all@freebsd.org Thu May 11 05:47:32 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6FB26D68FBF; Thu, 11 May 2017 05:47:32 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from mr11p00im-asmtp002.me.com (mr11p00im-asmtp002.me.com [17.110.69.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 549F51B9F; Thu, 11 May 2017 05:47:32 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from process-dkim-sign-daemon.mr11p00im-asmtp002.me.com by mr11p00im-asmtp002.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) id <0OPR00K00WNS3Y00@mr11p00im-asmtp002.me.com>; Thu, 11 May 2017 05:47:17 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mac.com; s=4d515a; t=1494481637; bh=BUg8AolDgRXnN62Ol1z1LyR+izu6sThdSFDhgnkE9Ds=; h=Date:Subject:From:To:Message-id:MIME-version:Content-type; b=r2gxOHT51dwFUJRq85lszDw4pl4Ghj4aOYYOLPXPvWv7jUvofNvpzLdbf3d4iewk+ L9tSXMn0YN86qMwBy98r5YBM5EQ6I1TgYmOtKRLCZoZvySFiu1hsM1mpEw413mX+6q lCZLwOscxxoWjJxYhumtFen1ABefFnz5f+wntjlOcxTHYLpK0bfGKykJSlQs/R1sYm X++JLxW8UUYOrohTjVMd2v0H2FdASxzwCi9g4BgfiOFR6brrxeQIgYpi1EAP14xbHI QA8AUkQzyLVlWT5Ae19/nh97WDyiBC6O/RzZUQp4tPexor2OOsLaoopjfEgoEcnZQn fbtgLJ7aMCVcQ== Received: from icloud.com ([127.0.0.1]) by mr11p00im-asmtp002.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) with ESMTPSA id <0OPR00LMQXERAG30@mr11p00im-asmtp002.me.com>; Thu, 11 May 2017 05:47:16 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-11_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1034 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1701120000 definitions=main-1705110036 User-Agent: Microsoft-MacOutlook/f.21.0.170409 Date: Wed, 10 May 2017 22:47:14 -0700 Subject: Re: svn commit: r318160 - in head: sbin/ifconfig sys/net sys/sys From: Ravi Pokala To: Kristof Provost Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-id: Thread-topic: svn commit: r318160 - in head: sbin/ifconfig sys/net sys/sys References: <201705102213.v4AMDlE2074710@repo.freebsd.org> <3F09C117-5017-481D-AAB2-7C64FF23B395@sigsegv.be> In-reply-to: MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 05:47:32 -0000 -----Original Message----- > From: on behalf of Kristof Provost > Date: 2017-05-10, Wednesday at 22:38 > To: Ravi Pokala > Cc: , , > Subject: Re: svn commit: r318160 - in head: sbin/ifconfig sys/net sys/sys >=20 > On 11 May 2017, at 11:05, Kristof Provost wrote: >> On 11 May 2017, at 3:43, Ravi Pokala wrote: >>> Author: rpokala >>> Date: Wed May 10 22:13:47 2017 >>> New Revision: 318160 >>> URL: https://svnweb.freebsd.org/changeset/base/318160 >>> >>> Log: >>> Persistently store NIC's hardware MAC address, and add a way to=20 >>> retrive it >>> >> >> This seems to cause panics when I create a bridge interface: >> >> #10 0xffffffff80ef9304 in bcopy () at=20 >> /usr/src/sys/amd64/amd64/support.S:139 >> #11 0xffffffff80b57a80 in ether_ifattach (ifp=3D0xfffff80035663000,=20 >> lla=3D0xfffff800090e13f8 "\002k") at /usr/src/sys/net/if_ethersubr.c:919 >> #12 0xffffffff8325dc67 in bridge_clone_create (ifc=3D> out>, unit=3D, params=3D) at=20 >> /usr/src/sys/net/if_bridge.c:704 >> ... >> >> ifp->if_hw_addr is NULL here: >> (kgdb) fr 11 >> #11 0xffffffff80b57a80 in ether_ifattach (ifp=3D0xfffff80035663000,=20 >> lla=3D0xfffff800090e13f8 "\002k") at /usr/src/sys/net/if_ethersubr.c:919 >> 919 bcopy(lla, ifp->if_hw_addr, ifp->if_addrlen); >> (kgdb) p ifp->if_hw_addr >> $1 =3D (void *) 0x0 >> >=20 > This may be because I=E2=80=99ve not yet updated world, just the kernel, but=20 > clearly that still shouldn=E2=80=99t cause panics. >=20 > Regards, > Kristof No, this is purely a kernel mistake -- I forgot to add a NULL-check in ethe= r_ifattach(). :-p Fixing now... -Ravi (rpokala@)