From owner-freebsd-stable@FreeBSD.ORG Wed Aug 30 03:23:31 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6632416A4DA; Wed, 30 Aug 2006 03:23:31 +0000 (UTC) (envelope-from ganbold@micom.mng.net) Received: from publicd.ub.mng.net (publicd.ub.mng.net [202.179.0.88]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50F5A43D49; Wed, 30 Aug 2006 03:23:30 +0000 (GMT) (envelope-from ganbold@micom.mng.net) Received: from [202.179.0.164] (helo=[192.168.0.18]) by publicd.ub.mng.net with esmtpa (Exim 4.61 (FreeBSD)) (envelope-from ) id 1GIGfg-000KLJ-9m; Wed, 30 Aug 2006 12:23:20 +0900 Message-ID: <44F504A8.8070503@micom.mng.net> Date: Wed, 30 Aug 2006 12:23:20 +0900 From: Ganbold User-Agent: Thunderbird 1.5.0.4 (X11/20060612) MIME-Version: 1.0 To: pyunyh@gmail.com References: <44F4F1DE.2030907@micom.mng.net> <20060830023537.GA47208@cdnetworks.co.kr> In-Reply-To: <20060830023537.GA47208@cdnetworks.co.kr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-stable@freebsd.org, glebius@freebsd.org, oleg@freebsd.org Subject: Re: panic: invalid ife->ifm_data (0xa) in mii_phy_setmedia X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2006 03:23:31 -0000 Hi, Thanks a lot for your patch. Your patch fixes panic, however I still see bge0: firmware handshake timed out bge0: link state changed to DOWN messages. When I tried to use Oleg's if_bge.c, rev. 1.140 in STABLE buildkernel stops: mkdep -f .depend -a -nostdinc -D_KERNEL -DKLD_MODULE -I- -DHAVE_KERNEL_OPTION_HEADERS -I. -I@ -I@/contrib/altq -I@/../include -I/usr/include -I/usr/obj/usr/src/sys/DEVIL /usr/src/sys/modules/bge/../../dev/bge/if_bge.c /usr/src/sys/modules/bge/../../dev/bge/if_bge.c:2570:35: macro "VLAN_INPUT_TAG" requires 4 arguments, but only 3 given mkdep: compile failed *** Error code 1 1 error *** Error code 2 1 error *** Error code 2 mkdep: compile failed *** Error code 1 2 errors *** Error code 2 1 error *** Error code 2 1 error I see VLAN_INPUT_TAG is defined as VLAN_INPUT_TAG(_ifp, _m, _t, _errcase) in if_vlan_var.h, rev v 1.21.2.2 with 4 arguments, however new if_bge.c, rev. 1.140 uses 3 arguments. Is it safe to use if_vlan_var.h, rev 1.24 and if_vlan.c, rev 1.114 only? What other patches should I use? When all these changes MFC to STABLE? thanks, Ganbold Pyun YongHyeon wrote: > I think your PHY was not recognized by brgphy(4). But I don't know it > fixes "firmware handshake timed out" issue you've seen. > Recently oleg fixed a long standing bug in bge(4). So you may also want > to merge the change.(See if_bge.c, rev. 1.140) > Patch generated against RELENG_6(compile tested only). > > > ------------------------------------------------------------------------ > > Index: miidevs > =================================================================== > RCS file: /home/ncvs/src/sys/dev/mii/miidevs,v > retrieving revision 1.30.2.3 > diff -u -r1.30.2.3 miidevs > --- miidevs 8 Aug 2006 07:51:21 -0000 1.30.2.3 > +++ miidevs 30 Aug 2006 02:28:07 -0000 > @@ -118,6 +118,7 @@ > model xxBROADCOM BCM5400 0x0004 Broadcom 1000baseTX PHY > model xxBROADCOM BCM5401 0x0005 BCM5401 10/100/1000baseTX PHY > model xxBROADCOM BCM5411 0x0007 BCM5411 10/100/1000baseTX PHY > +model xxBROADCOM BCM5752 0x0010 BCM5752 10/100/1000baseTX PHY > model xxBROADCOM BCM5701 0x0011 BCM5701 10/100/1000baseTX PHY > model xxBROADCOM BCM5703 0x0016 BCM5703 10/100/1000baseTX PHY > model xxBROADCOM BCM5704 0x0019 BCM5704 10/100/1000baseTX PHY > Index: brgphy.c > =================================================================== > RCS file: /home/ncvs/src/sys/dev/mii/brgphy.c,v > retrieving revision 1.34.2.6 > diff -u -r1.34.2.6 brgphy.c > --- brgphy.c 8 Aug 2006 04:37:18 -0000 1.34.2.6 > +++ brgphy.c 30 Aug 2006 02:28:07 -0000 > @@ -126,6 +126,12 @@ > } > > if (MII_OUI(ma->mii_id1, ma->mii_id2) == MII_OUI_xxBROADCOM && > + MII_MODEL(ma->mii_id2) == MII_MODEL_xxBROADCOM_BCM5752) { > + device_set_desc(dev, MII_STR_xxBROADCOM_BCM5752); > + return(BUS_PROBE_DEFAULT); > + } > + > + if (MII_OUI(ma->mii_id1, ma->mii_id2) == MII_OUI_xxBROADCOM && > MII_MODEL(ma->mii_id2) == MII_MODEL_xxBROADCOM_BCM5701) { > device_set_desc(dev, MII_STR_xxBROADCOM_BCM5701); > return(BUS_PROBE_DEFAULT); > @@ -665,6 +671,7 @@ > bcm5704_load_dspcode(sc); > break; > case MII_MODEL_xxBROADCOM_BCM5750: > + case MII_MODEL_xxBROADCOM_BCM5752: > case MII_MODEL_xxBROADCOM_BCM5714: > case MII_MODEL_xxBROADCOM_BCM5780: > case MII_MODEL_xxBROADCOM_BCM5706C: >