Date: Tue, 18 Jan 2011 14:58:44 +0000 (UTC) From: John Baldwin <jhb@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r217537 - head/sys/dev/acpica Message-ID: <201101181458.p0IEwiXq041498@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jhb Date: Tue Jan 18 14:58:44 2011 New Revision: 217537 URL: http://svn.freebsd.org/changeset/base/217537 Log: Remove bogus check. pcib_get_bus() (like other BUS_ACCESSOR() methods) doesn't "fail", it may merely return garbage if it is not a valid ivar for a given device. Our parent device must be a 'pcib' device, so we can just assume it implements pcib IVARs, and all pcib devices have a bus number. Submitted by: clang via rdivacky Modified: head/sys/dev/acpica/acpi_pci.c Modified: head/sys/dev/acpica/acpi_pci.c ============================================================================== --- head/sys/dev/acpica/acpi_pci.c Tue Jan 18 14:58:12 2011 (r217536) +++ head/sys/dev/acpica/acpi_pci.c Tue Jan 18 14:58:44 2011 (r217537) @@ -281,8 +281,6 @@ static int acpi_pci_probe(device_t dev) { - if (pcib_get_bus(dev) < 0) - return (ENXIO); if (acpi_get_handle(dev) == NULL) return (ENXIO); device_set_desc(dev, "ACPI PCI bus");
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101181458.p0IEwiXq041498>