From owner-cvs-all@FreeBSD.ORG  Sat Sep 16 21:53:38 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DE7BF16A412;
	Sat, 16 Sep 2006 21:53:38 +0000 (UTC)
	(envelope-from phk@phk.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 020E843D76;
	Sat, 16 Sep 2006 21:53:34 +0000 (GMT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id 6BB8F170C5;
	Sat, 16 Sep 2006 21:53:33 +0000 (UTC)
To: Matt Jacob <mjacob@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sat, 16 Sep 2006 21:21:07 GMT."
	<200609162121.k8GLL7rt005933@repoman.freebsd.org> 
Date: Sat, 16 Sep 2006 21:53:24 +0000
Message-ID: <71137.1158443604@critter.freebsd.dk>
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Sep 2006 21:53:39 -0000

In message <200609162121.k8GLL7rt005933@repoman.freebsd.org>, Matt Jacob writes
:
>mjacob      2006-09-16 21:21:07 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/cam/scsi         scsi_da.c 
>  Log:
>  Don't allow attachment of disks that could cause GEOM to panic.

The correct commit message would have been:

   Don't allow attachment of disks which we couldn't possibly do I/O from.

The problem is that there is a fixed upper limit for the I/O transfer
sizes we support (this should be fixed) and if the sectorsize is
larger, we're hosed.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.