From owner-cvs-all@FreeBSD.ORG Sat Oct 23 08:33:10 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9498D16A4CE; Sat, 23 Oct 2004 08:33:10 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 886DE43D1D; Sat, 23 Oct 2004 08:33:10 +0000 (GMT) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9N8XA8v077060; Sat, 23 Oct 2004 08:33:10 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9N8XA8R077059; Sat, 23 Oct 2004 08:33:10 GMT (envelope-from mtm) Message-Id: <200410230833.i9N8XA8R077059@repoman.freebsd.org> From: Mike Makonnen Date: Sat, 23 Oct 2004 08:33:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/bfe if_bfe.c if_bfereg.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 08:33:10 -0000 mtm 2004-10-23 08:33:10 UTC FreeBSD src repository Modified files: sys/dev/bfe if_bfe.c if_bfereg.h Log: Locking cleanups to remove the need for a recursive mutex o Instead of locking and unlocking all over the place, use lock assertions to make certain that the bfe lock is held where necessary. o Create locked and unlocked versions of bfe_init and bfe_start. These functions can be called from outside the module and by functions within the bfe module. The calls from outside the module don't hold the bfe lock so the unlocked versions called by these functions simple obtain the bfe lock and call the locked version. - Fix a typo (scp) in the locking macros that only worked because in all the instances in which it was called the softc pointer happened to be named 'sc'. - Mark the interrupt MPSAFE Tested by: matusita, Dario Freni Silence from: -net, wpaul Revision Changes Path 1.18 +46 -58 src/sys/dev/bfe/if_bfe.c 1.5 +3 -2 src/sys/dev/bfe/if_bfereg.h