From nobody Sun Sep 21 17:17:51 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cVCcX4WtCz68PMk for ; Sun, 21 Sep 2025 17:18:04 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cVCcX29dWz3D74 for ; Sun, 21 Sep 2025 17:18:04 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-826fe3b3e2bso390719185a.0 for ; Sun, 21 Sep 2025 10:18:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758475083; x=1759079883; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9d1SNNKLJnhMlyk9P2ED2Z9gB7FVsYvu5nLHdMH8OLQ=; b=OVMpV9nSiw0jpaJYH+yDX4n0BAaw8+3AAcx9PodOrRickPN/2lJg8ej7bTMQv/uq8A /C37WF4tqG+H+ldL4hU+nlZ9DvRTpq3Rk077XU0suV0ISHM+ez8myYGKrDFQQbx0fIXc cCpQMQimY/th6XWIWw1ldBaGymNYBAsE6L8uqQEff8NNtywhFjUlmEEMxxzEUuenN5lz vAL+fT76rV5iocC5s0zI3eLQ2q5Fo4oOa1TkmQEdde1HpvhXFqlwzbpyHIOJNAIwodme y+V7DlOkK96NBiFovLXDP8Zhuf+G/jzIgh2uEKs8bGJ2vRW+FhkMwbf6DIBHvC7yj5fD 4+RA== X-Forwarded-Encrypted: i=1; AJvYcCVAL3v88BTuaTIDwYOL51vu84WzUWbMaDZ163Hku1d7bQTAR2n3zd67OxS+OII+tgsSyv974nO2/Q0wPzuaqoSHFk7fbg==@freebsd.org X-Gm-Message-State: AOJu0YyoxmZjBUbjKFncN3HWCri2xfFj/xR4XgyS6GISc7GqquuIJQg1 HYnzRlqfwNhvcEt+ejUVVthOeC5rDuy+h2lx3hazM1v/9YgXcc7BKZPK3o1/zCWfkvZu7qlN6Zp 6F53Wlx//Giid7mxVWaiPl4WV5LDtoIg= X-Gm-Gg: ASbGncs57kOhP2jJnnshiS5cR3nXzx8iePxSYTbKIEd1VRTQlyNUjIVwpMvd8+7RUN1 hGOFYK+WoowMfsWbCrcYB2VbcMptQ4yL7udDBPMWLfcjSL1ExWNSk0EyuFFZS4mgHm9x/QbNBFV Xml4ZCpT1ZbYwIeFLEUBFcvRQJrMRl/w2I8XtibMhRdYUZNfj1kXiHdNo+RZjGVj0jkpRWnKxfn /yRf9Y= X-Google-Smtp-Source: AGHT+IESn7uyuTtXUvgAHGSSP+7Y/J8JANJCO/ccaxfu1VjuUKv+OuLKJEYOxzA7YISS2HIa6zHtp+euxSrlKS+MbyI= X-Received: by 2002:a05:620a:a81b:b0:84b:4091:160c with SMTP id af79cd13be357-84b40911657mr48055385a.65.1758475082943; Sun, 21 Sep 2025 10:18:02 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202509200047.58K0lcgE017026@gitrepo.freebsd.org> In-Reply-To: From: Adrian Chadd Date: Sun, 21 Sep 2025 10:17:51 -0700 X-Gm-Features: AS18NWC_H9aoQ4jzpzAz92JQy6US8Qkupkp_vdYOvR_3u2OstgtH-URGrX3zjKM Message-ID: Subject: Re: git: 785edcc2af5a - main - net80211: convert the rest of the native net80211 drivers to SEQNO_OFFLOAD To: Gleb Smirnoff Cc: bz@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000aa5141063f52e24e" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cVCcX29dWz3D74 --000000000000aa5141063f52e24e Content-Type: text/plain; charset="UTF-8" On Sun, 21 Sept 2025 at 01:29, Gleb Smirnoff wrote: > Hi, > > On Sat, Sep 20, 2025 at 12:47:38AM +0000, Adrian Chadd wrote: > A> commit 785edcc2af5ae32c24f5caf5b9552f62bdae33ee > A> Author: Adrian Chadd > A> AuthorDate: 2025-06-10 04:22:10 +0000 > A> Commit: Adrian Chadd > A> CommitDate: 2025-09-20 00:42:45 +0000 > A> > A> net80211: convert the rest of the native net80211 drivers to > SEQNO_OFFLOAD > A> > A> * Convert the rest of the drivers to implement driver/offloaded > sequence > A> number handling. > A> > A> * For drivers that implement their own sequence number space > handling > A> for A-MPDU, only call ieee80211_output_seqno_assign() if the frame > A> isn't tagged with M_AMPDU_MPDU, which mirrors the original > net80211 > A> sequence number behaviour. (Except of course, the assignment is > A> now happening during final encap/transmit, not early in encap.) > A> > A> Locally tested (sta mode): > A> > A> * ath > A> * iwn > A> * bwi > A> * bwn > A> * iwm > A> * otus > A> * ral > A> > A> Differential Revision: https://reviews.freebsd.org/D50772 > A> Okayed by: bz > > This commit broke my iwm(4) on Thinkpad X1 Carbon 7th Gen. > > The symptoms are that the interface can associate and even receive DHCP > address, but after that all transmitted packets are lost. Any > communication > attempt results in ARP requests that are not seen by other devices on the > network. Reverting this commit resolves the problem. > > I will be able to test patches tomorrow, please send them to me. > > If we are not able to resolve that before start of the stabweek which is > this > Monday, I'd like to get this reverted from main. > Yup, I figured it out pretty quickly after it was first reported. See: https://reviews.freebsd.org/D52652 It looks like different generations of firmware/chipsets have different expectations for sequence numbers being present. I'm going to land this once kevans (and/or you?) test it out and OK it. Sorry! -a > > -- > Gleb Smirnoff > --000000000000aa5141063f52e24e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sun, 21 Sept= 2025 at 01:29, Gleb Smirnoff <gl= ebius@freebsd.org> wrote:
=C2=A0 Hi,

On Sat, Sep 20, 2025 at 12:47:38AM +0000, Adrian Chadd wrote:
A> commit 785edcc2af5ae32c24f5caf5b9552f62bdae33ee
A> Author:=C2=A0 =C2=A0 =C2=A0Adrian Chadd <adrian@FreeBSD.org> A> AuthorDate: 2025-06-10 04:22:10 +0000
A> Commit:=C2=A0 =C2=A0 =C2=A0Adrian Chadd <adrian@FreeBSD.org> A> CommitDate: 2025-09-20 00:42:45 +0000
A>
A>=C2=A0 =C2=A0 =C2=A0net80211: convert the rest of the native net80211 = drivers to SEQNO_OFFLOAD
A>=C2=A0 =C2=A0 =C2=A0
A>=C2=A0 =C2=A0 =C2=A0* Convert the rest of the drivers to implement dri= ver/offloaded sequence
A>=C2=A0 =C2=A0 =C2=A0 =C2=A0number handling.
A>=C2=A0 =C2=A0 =C2=A0
A>=C2=A0 =C2=A0 =C2=A0* For drivers that implement their own sequence nu= mber space handling
A>=C2=A0 =C2=A0 =C2=A0 =C2=A0for A-MPDU, only call ieee80211_output_seqn= o_assign() if the frame
A>=C2=A0 =C2=A0 =C2=A0 =C2=A0isn't tagged with M_AMPDU_MPDU, which m= irrors the original net80211
A>=C2=A0 =C2=A0 =C2=A0 =C2=A0sequence number behaviour.=C2=A0 (Except of= course, the assignment is
A>=C2=A0 =C2=A0 =C2=A0 =C2=A0now happening during final encap/transmit, = not early in encap.)
A>=C2=A0 =C2=A0 =C2=A0
A>=C2=A0 =C2=A0 =C2=A0Locally tested (sta mode):
A>=C2=A0 =C2=A0 =C2=A0
A>=C2=A0 =C2=A0 =C2=A0* ath
A>=C2=A0 =C2=A0 =C2=A0* iwn
A>=C2=A0 =C2=A0 =C2=A0* bwi
A>=C2=A0 =C2=A0 =C2=A0* bwn
A>=C2=A0 =C2=A0 =C2=A0* iwm
A>=C2=A0 =C2=A0 =C2=A0* otus
A>=C2=A0 =C2=A0 =C2=A0* ral
A>=C2=A0 =C2=A0 =C2=A0
A>=C2=A0 =C2=A0 =C2=A0Differential Revision:=C2=A0 https://revi= ews.freebsd.org/D50772
A>=C2=A0 =C2=A0 =C2=A0Okayed by: bz

This commit broke my iwm(4) on Thinkpad X1 Carbon 7th Gen.

The symptoms are that the interface can associate and even receive DHCP
address, but after that all transmitted packets are lost.=C2=A0 Any communi= cation
attempt results in ARP requests that are not seen by other devices on the network.=C2=A0 Reverting this commit resolves the problem.

I will be able to test patches tomorrow, please send them to me.

If we are not able to resolve that before start of the stabweek which is th= is
Monday, I'd like to get this reverted from main.
<= br>
Yup, I figured it out pretty quickly after it was first repor= ted.


It looks like different generations of firmware/chipsets have different ex= pectations for
sequence numbers being present. I'm going to l= and this once kevans (and/or you?)
test it out and OK it.

Sorry!



=
-a
=C2=A0

--
Gleb Smirnoff
--000000000000aa5141063f52e24e--