From owner-svn-ports-head@freebsd.org Thu Oct 19 20:29:14 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D97DE46863; Thu, 19 Oct 2017 20:29:14 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 15F3E7E8E5; Thu, 19 Oct 2017 20:29:14 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from lrrr.mouf.net (cpe-24-163-43-246.nc.res.rr.com [24.163.43.246]) (authenticated bits=0) by mouf.net (8.14.9/8.14.9) with ESMTP id v9JKT3ul097461 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 19 Oct 2017 20:29:09 GMT (envelope-from swills@FreeBSD.org) Subject: Re: svn commit: r452419 - in head/graphics: . ptex ptex/files To: Jan Beich Cc: Shane , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201710191310.v9JDAmdQ047764@repo.freebsd.org> From: Steve Wills Message-ID: <1405827a-df6f-26fb-f769-c42cd77ba101@FreeBSD.org> Date: Thu, 19 Oct 2017 16:28:59 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Thu, 19 Oct 2017 20:29:09 +0000 (UTC) X-Spam-Status: No, score=1.3 required=4.5 tests=RCVD_IN_RP_RNBL autolearn=no autolearn_force=no version=3.4.1 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net X-Virus-Status: Clean X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2017 20:29:14 -0000 Hi, On 10/19/2017 14:00, Jan Beich wrote: > Steve Wills writes: > >> +PORTNAME= ptex > [...] >> +GH_PROJECT= ptex > > One of these is redundant. > >> +PORTVERSION= 2.1.28 >> +GH_TAGNAME= v${PORTVERSION} > > Use DISTVERSIONPREFIX. > > https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex3 > Yeah, sorry, I should have looked closer at these. >> +DOCS_BUILD_DEPENDS= doxygen:devel/doxygen > > Maybe rename to DOXYGEN, so users can disable it globally via OPTIONS_UNSET. > DOCS is enabled by default, so you may want to enable DOXYGEN as well. > > https://lists.freebsd.org/pipermail/freebsd-ports/2015-March/098258.html > https://svnweb.freebsd.org/changeset/ports/428947 > https://svnweb.freebsd.org/changeset/ports/429005 > https://svnweb.freebsd.org/changeset/ports/429007 > https://svnweb.freebsd.org/changeset/ports/429087 > https://svnweb.freebsd.org/changeset/ports/429088 > https://svnweb.freebsd.org/changeset/ports/429089 > https://svnweb.freebsd.org/changeset/ports/429090 > https://svnweb.freebsd.org/changeset/ports/429091 > https://svnweb.freebsd.org/changeset/ports/429092 > https://svnweb.freebsd.org/changeset/ports/429093 > https://svnweb.freebsd.org/changeset/ports/429094 > https://svnweb.freebsd.org/changeset/ports/429095 > https://svnweb.freebsd.org/changeset/ports/429096 > https://svnweb.freebsd.org/changeset/ports/429098 > https://svnweb.freebsd.org/changeset/ports/429099 > https://svnweb.freebsd.org/changeset/ports/429228 (reverts r429099) > https://svnweb.freebsd.org/changeset/ports/429229 (reverts r429097) > I'll have to look at this more, but right now I'm leaning against making a special case just because the docs are built with Doxygen. (Yes, the ruby ports have it, but they also have other docs, so the doxygen docs there are more like "additional docs" and aren't really that useful.) >> +.include > > Unused line. Nothing later uses .if/.for conditionals. > Ok, that makes sense. >> ++#if !defined(__FreeBSD__) >> + #include >> ++#endif > > None of BSDs have , including DragonFly which is a downstream > consumer of FreeBSD Ports. > Right, hence not including it if __FreeBSD__ is defined. What change are you looking for? Steve