From nobody Mon Oct 7 14:07:08 2024 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XMgvP4scqz5YBgS for ; Mon, 07 Oct 2024 14:07:13 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XMgvP1mRMz4Z4j for ; Mon, 7 Oct 2024 14:07:13 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-7a9b72749bcso382829685a.0 for ; Mon, 07 Oct 2024 07:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728310032; x=1728914832; darn=freebsd.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=TdnejahIwdWqiDOsYkIGgBoICtEzokNbHClxF6+8bqY=; b=PwqbwVDwtaw9zfzkewub5P/GzyNwzcBXRaK+Z+gCfeSxYBpa6eP7PGhUf/fcvtrCfF yOcRSA+K0e05avi6qFCj31SEALC8bIAOSAT6bUecm3uHgh4vWpPA/CH9Gz3+8fMqeUei xBb0ez66zmortBTATYTb69IJwZzY/xmBcGRZr+TgvVzx753YRl1SEB1FTWK5iGs5yMxD P60Yqk6rnTEtw13/81O/Gee5Z7fSHZcmJhbya1Ixmel7erxwReQ+JSVn7/C7Zjqk33tE MVJ57ywu8H00ShkAhLlPd0wNyYd1nHFrd+ZlfFWHVdtUCGkZvdDVi6sLPYF1ssIRhOOt m/PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728310032; x=1728914832; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TdnejahIwdWqiDOsYkIGgBoICtEzokNbHClxF6+8bqY=; b=vBLOP2mUbcNR8LlpPuG8Oo/yqTUm2b6W0GsIDGx6Og1t9ie71w4ILgTKsBAqf3+ARe 9mcHVti7VdxqLle3/3PP482CWkt38gi1E4siSBawQ0mycdsTxnWcsY0tp4TVmo4OA9aY kBT9W9HZ78eWUFAOHWJyjGvxcxq97/6z19rh+o2qOkq5qBrCLtcMMe9BsevhxDu6DZWd cw9pSod54KJh7WfpCZ7NPOdLytFvNk1zYeSKGi1L+OtrKXYYY6gLKAMrxgLPVagM6C+P IHopzR/nH+aqOcSrS945TIyU3Sag2fT12LUbQbacxUOGhTlrn3YUrBmG6IahNl/CjIbC r5tg== X-Gm-Message-State: AOJu0Yxm70mp+Bbdpdh1T5nIbn4E1KOMUHZbbUPCN/mltylCi2dmJ8YD PRXeXPOSi3nbTzNsXEtLmBXmakLhpDxoJgLT71ZMYQb0BPcV38YTsyKBog== X-Google-Smtp-Source: AGHT+IHlkIGy+UGzGcoVXZaW+ujZpy6lcQZBGRT1QzlV6Y5VDSRQYRevbRAYtLVOwRhZL4s+xdXlsQ== X-Received: by 2002:a05:620a:4108:b0:7a9:bf2a:d7c8 with SMTP id af79cd13be357-7ae6f486015mr1809873185a.41.1728310031667; Mon, 07 Oct 2024 07:07:11 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae7562bdf6sm258668185a.43.2024.10.07.07.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 07:07:11 -0700 (PDT) Date: Mon, 7 Oct 2024 10:07:08 -0400 From: Mark Johnston To: "David E. Cross" Cc: FreeBSD Hackers Subject: Re: Review D38047 ... and then there was one.... Message-ID: References: <21941f7f-ce32-e277-a565-b1db3b3841ab@crossfamilyweb.com> List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <21941f7f-ce32-e277-a565-b1db3b3841ab@crossfamilyweb.com> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4XMgvP1mRMz4Z4j X-Spamd-Bar: ---- On Sun, Oct 06, 2024 at 02:35:18PM -0400, David E. Cross wrote: > As I have been prodding about open reviews, there is now only one that > hasn't had any action.  One that is complete and in main (OMGYES), and one > that is at the finish line (I think). > > > That leaves just D38047 ( https://reviews.freebsd.org/D38047 ) ... Submitted > Jan 13, **2023**, had initial peer review requests, I made all requested > changes (or explained why I didn't)  Made my last substantive changes Aug 4, > **2023**, I have since then semi-regularly updated with fresh rebases, but > no other changes. > > > Please, love to get some eyes on this.  As it stands nscd is completely > useless for LDAP for getgroupmembership (and really ANY implementation that > defines a specific implementation of getgroupmembership, since it will then > bypass the non-existent NSCD version).  Additionally it fixes bugs with > negative caching as well as increases thread safety. One problem with this patch is that it fixes several bugs at once. Though the process can be a bit tedious, it's much easier to review smaller, self-contained patches which fix a single problem. The change to the nscd Makefile plus the cycle prevention symbol rename, for instance, can be committed on its own. I left some comments on the review in any case. If you could split the patch into several smaller ones, it'd be greatly appreciated. > I've been running this successfully with LDAP for years now.