From owner-freebsd-security  Sat Jun  8 20:46: 2 2002
Delivered-To: freebsd-security@freebsd.org
Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5])
	by hub.freebsd.org (Postfix) with ESMTP id 27C6037B401
	for <security@FreeBSD.org>; Sat,  8 Jun 2002 20:45:58 -0700 (PDT)
Received: from hades.hell.gr (patr530-b179.otenet.gr [212.205.244.187])
	by mailsrv.otenet.gr (8.12.3/8.12.3) with ESMTP id g593jlZN028425;
	Sun, 9 Jun 2002 06:45:49 +0300 (EEST)
Received: from hades.hell.gr (hades [127.0.0.1])
	by hades.hell.gr (8.12.3/8.12.3) with ESMTP id g593jkUP098514;
	Sun, 9 Jun 2002 06:45:46 +0300 (EEST)
	(envelope-from keramida@FreeBSD.org)
Received: (from charon@localhost)
	by hades.hell.gr (8.12.3/8.12.3/Submit) id g5934cC4089159;
	Sun, 9 Jun 2002 06:04:38 +0300 (EEST)
	(envelope-from keramida@FreeBSD.org)
Date: Sun, 9 Jun 2002 06:04:36 +0300
From: Giorgos Keramidas <keramida@FreeBSD.org>
To: Roger Marquis <marquis@roble.com>
Cc: security@FreeBSD.org
Subject: Re: Pine 4.44 Privacy Patch
Message-ID: <20020609030436.GB79791@hades.hell.gr>
References: <3D028157.28F86BD7@FreeBSD.org> <20020608160053.I40521-100000@roble.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020608160053.I40521-100000@roble.com>
Sender: owner-freebsd-security@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-security.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-security>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-security>
X-Loop: FreeBSD.org

On 2002-06-08 16:04 -0700, Roger Marquis wrote:
> DiCioccio, Jason <jdicioccio@epylon.com> wrote:
> >Am I crazy or do his comments EVER get closed?  Looks wrong to me
>
> That's because it's a patch, not a comment.  If you don't modify
> comment endings they don't show up in the patch.  See diff (1) for
> details.

Can you elaborate on this?  My diff(1) manpage seems to have
absolutely no comments for comments...

	$ man 1 diff | col -b | fgrep comment
	$

Moreover, here's a demo that shows comments pose no problem for diff
output.  No problem at all:

	$ cat > foo
	/*
	 * A comment.
	 */

	$ cat > foo2
	/*
	 * A comment.
	 * Yet another comment.
	 */

	$ diff -u foo foo2
	--- foo Sun Jun  9 06:01:29 2002
	+++ foo2        Sun Jun  9 06:01:47 2002
	@@ -1,3 +1,4 @@
	 /*
	  * A comment.
	+ * Yet another comment.
	  */

Please do not state things that make well known programs, like diff,
look like they have some bug or misfeature, without providing details.
Especially on a list that's supposed to be a -security list.

- Giorgos


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message