Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 14 Oct 2020 08:46:43 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r552302 - head/net/nifmon/files
Message-ID:  <20201014064643.rg2rd7usrsixpjdi@ivaldir.net>
In-Reply-To: <202010140641.09E6fPUD010851@repo.freebsd.org>
References:  <202010140641.09E6fPUD010851@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--74ntr7e37lhrusoz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 14, 2020 at 06:41:25AM +0000, Alexey Dokuchaev wrote:
> Author: danfe
> Date: Wed Oct 14 06:41:24 2020
> New Revision: 552302
> URL: https://svnweb.freebsd.org/changeset/ports/552302
>=20
> Log:
>   Force -fcommon to unbreak the build against Clang 11 and GCC 10.
>  =20
>   PR:	250219
I don't understand why you have to patch the Makefile here, -fcommon if pas=
sed
should be passed by the port CFLAGS and if it does not work than the upstre=
am
Makefile should be patch to support this.

In any case the current approach seems wrong to me.

Best regards,
Bapt

--74ntr7e37lhrusoz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl+Gns4ACgkQY4mL3PG3
PlrWNg//ULBdrtyiJsMwpT085WMU3HwAo04IsMNOAUstIHTy0bKsavrF5rXfFwbC
iV3QGi4Ke87ojSmO9A3sFKt0HG49cwilsy9Ll5RsOBP38ZCUIp3D3sG7DaX9BhiJ
1MhQ+5SKlV0mKkYUDFs5pS9R0KvapoAwZzuzBMxyGIQgL+zw8Zr2epAoG72DR0TM
lr4YgTgkVCnzWhFzl2daXkPI9vNnDt1MGw3Oc24ldBSq9tsRzI+vrqZsLCVniDuC
pNHBY66pkXhMUx7EqmHnqO3szcgKDcICnhLNpGScHBEpWtRxOyxHcPG+DmG+kk6y
qsuULZ8MbZPzu9URB0uc7ssZvnIsb3t6Kzu1fXHS2a0RjiNpvgNc3C/MXXaQCTfN
5x2Pa/tlTn/6jMP5a2SwT998pPkp6Z8Vxx4R3t0jD0947YPFJqt4GbHIyOoA8VeH
DNvUZYg6ysUsmHROMETZ+qTlk6rB36IC8JxC5e6LkAAmsc2qYYHdtK9YtkqhAgNX
lw66lSzrERhkdfjtu+KFNVgdXN672n5PJuGeZ2YwYoDKm04AidS6pEWUmigZ5D89
e+qVBJqwsT/U10vJibtf2Ix14Xi6+upSMMXTEMDN8W648++HwX+qUwMOIq3rOI0R
9lIARsn8p8lyY55xuHvriWmfUsHTuaaN+aGViEPjh5hfdXukmCo=
=4K4N
-----END PGP SIGNATURE-----

--74ntr7e37lhrusoz--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201014064643.rg2rd7usrsixpjdi>