From owner-svn-src-all@freebsd.org Wed Apr 20 15:06:53 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 98CA7B1616E for ; Wed, 20 Apr 2016 15:06:53 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm30-vm0.bullet.mail.bf1.yahoo.com (nm30-vm0.bullet.mail.bf1.yahoo.com [98.139.213.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4E3B61985 for ; Wed, 20 Apr 2016 15:06:53 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1461164804; bh=zoiaeODonzQ3jxS4/SturDAKnI4Ina1ajkrNo2Rj3DQ=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=g8DH2XDnmNXGHAjlQndxuUcDvCMeWMP9ec3jw2CjA/0xUffQ+eEg/LNfNKxddkeCpnl9s93Izkqbnz5BAeqGTWoHnZ4MNwFPsjEXZ+URMBMq8mTrzkAxan8L/3iCMGJ+LeUT3x+Ts4K72xaI5ar4qlvlQyuO4waUmtGIWbqrpOq0yKTJvpg9jbRhShyrnPj+mHADF3/r2k+uF9iL6DKccsMJDznuaHOsuI8VNbHkrStBt/j86z/E3j8WGuU5s9MjD22e2kdONxLw9VtmEuFtoBVhDR99fO0qfiTZ/DnKyKpDzehuhBrI80maYlWHF/W/miDPaYY9gPO1v9sGpgt/sw== Received: from [98.139.214.32] by nm30.bullet.mail.bf1.yahoo.com with NNFMP; 20 Apr 2016 15:06:44 -0000 Received: from [68.142.230.74] by tm15.bullet.mail.bf1.yahoo.com with NNFMP; 20 Apr 2016 15:06:44 -0000 Received: from [127.0.0.1] by smtp231.mail.bf1.yahoo.com with NNFMP; 20 Apr 2016 15:06:44 -0000 X-Yahoo-Newman-Id: 896411.82476.bm@smtp231.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: hibHc90VM1k0t8F8.c37vIHNicIh0gmjGbxxgpBsxH4aWm0 _GwUqCs2.QC_x.2jb85M_e6dcw3uW83b7haSHSiGtAHEQ4dpgAKGhJRGzuCc aHXYpey_2yyDlFOGi7AuDKA_8fKHAfPYS3n2sMvq7MDyho3WjIgVwgt29kA0 GGNjWXswJ89DeS0tJd6JdtgmOuTyveQOgb4MT0.3K.mzxBe70FhnrTWXOz9D HZ9VO6zZrXM.x3ZmdHvbLHHA53SPW0Atck0NdSaMIDO0CraSOSJ7QPontqP4 sijpCRLn8jU643AzzsFCOTfqO0ZF97_H3Sv965p2OzKZEICGyvOPG0x0BH1c 3cLCXtu_pkTjppbHQ6jTRFrCdcNOR31JuXEeJN4e1EdlMnd5BIw2YuAgr9il elfqaArH9HUShhu_FpZqVQOgQBz5rJyPMk0Hg3Ys.RzebN.Hd7YfE6Aub95v mpgq29MVcMsxOu9Fl9v0mutTyMkQ32w1LXESP_mbPfe00F7NDlpYpE3gKPOd pRkRtZt3fdCsu0QxvmFStQZrCMlhKyQNO X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r298247 - head/sbin/fdisk_pc98 To: cem@FreeBSD.org References: <201604190446.u3J4kD9G050780@repo.freebsd.org> <4114217.PtcV9LDMal@ralph.baldwin.cx> <20160420115844.Y967@besplex.bde.org> <3ddd1087-e83a-d14c-1cc2-951a6d23306f@FreeBSD.org> Cc: Bruce Evans , araujo@freebsd.org, John Baldwin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Pedro Giffuni Message-ID: <753495a5-9ccd-1ec8-6f62-4006ff0345e2@FreeBSD.org> Date: Wed, 20 Apr 2016 10:06:49 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <3ddd1087-e83a-d14c-1cc2-951a6d23306f@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2016 15:06:53 -0000 On 04/20/16 10:04, Pedro Giffuni wrote: > > > On 04/20/16 09:41, Conrad Meyer wrote: >> On Wed, Apr 20, 2016 at 7:33 AM, Pedro Giffuni wrote: >>> One of the things I dislike is that most of the macros are in >>> lowercase. Lowercase would make sense if these were inline functions >>> but inline functions have disadvantages for these use cases. >>> OTOH, if they were uppercase, they would not be very easy on the eyes, >>> which is the current advantage. >> >> >> You bring up a good point. Obviously nitems() can't be an inline >> function, but roundup2() and friends could. Is there any reason not >> to change them over to inline functions? >> > > That would be interesting. The question would be if there are type > issues. I guess most uses require ints but some many use size_t. > s/many/may/ Pedro.