From owner-cvs-all@FreeBSD.ORG Wed Apr 13 20:39:27 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3CCC116A4CE; Wed, 13 Apr 2005 20:39:27 +0000 (GMT) Received: from barton.dreadbsd.org (massena-4-82-67-196-50.fbx.proxad.net [82.67.196.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7DA2643D55; Wed, 13 Apr 2005 20:39:26 +0000 (GMT) (envelope-from antoine@massena-4-82-67-196-50.fbx.proxad.net) Received: from barton.dreadbsd.org (localhost [127.0.0.1]) by barton.dreadbsd.org (8.13.3/8.13.1) with ESMTP id j3DKdP2g029432; Wed, 13 Apr 2005 22:39:25 +0200 (CEST) (envelope-from antoine@massena-4-82-67-196-50.fbx.proxad.net) Received: (from antoine@localhost) by barton.dreadbsd.org (8.13.3/8.13.1/Submit) id j3DKdO7A029431; Wed, 13 Apr 2005 22:39:24 +0200 (CEST) (envelope-from antoine) Date: Wed, 13 Apr 2005 22:39:24 +0200 From: Antoine Brodin To: Alfred Perlstein Message-Id: <20050413223924.75ac1047.antoine.brodin@laposte.net> In-Reply-To: <20050413195312.GD60345@elvis.mu.org> References: <200504130001.j3D01kuD081602@repoman.freebsd.org> <20050413184246.19212b84.antoine.brodin@laposte.net> <20050413124956.M3762@sasami.jurai.net> <20050413195312.GD60345@elvis.mu.org> X-Mailer: Sylpheed version 1.9.8 (GTK+ 2.6.7; i386-portbld-freebsd6.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: mdodd@freebsd.org Subject: Re: cvs commit: src/share/man/man4 unix.4 src/sys/sys socket.h un.h unpcb.h src/sys/kern uipc_usrreq.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2005 20:39:27 -0000 Alfred Perlstein wrote: > * Matthew N. Dodd [050413 10:04] wrote: > > On Wed, 13 Apr 2005, Antoine Brodin wrote: > > >I'm not sure it's safe to sooptcopyout/sooptcopyin while holding the > > >unp mutex in uipc_ctloutput. It can fault. > > > > I was concerned about this but saw that other code holds locks across > > sooptcopy*() calls. > > > > If there is a deadlock problem it may be time to add a per unpcb lock. > > This should be tripping an assertion, copyout/copyin is not ok while > holding a mutex. Does anyone want to add the logic to sooptcopy*? A simple WITNESS_WARN(WARN_GIANTOK|WARN_SLEEPOK, NULL, "Sleeping in sofoo"); should do the trick. Cheers, Antoine