From nobody Sun Jul 27 08:21:44 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bqZMX6w4jz627Kr; Sun, 27 Jul 2025 08:21:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bqZMX5cPGz3w6b; Sun, 27 Jul 2025 08:21:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753604504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o7WyYSiwy8q/P1M8aQG3YkzfxkLTWP/jhXLkfJqIusQ=; b=vgAOhu+Cbo0Cng+OyaV8EeDCJcdVMlvQX0trFA5skNxVeO2FKbqhDz1yh8UCVxGvAZhXmR ne3VfxpibSPrBq2Yb+tr0LgCfNt0B4Yerpor1qaDmraopzcZNB03k7OKa49r9TNcAuYxhY kDmowTZ2iThWXcU27pOGrwDv9nmmd3LUUI61gJ2i1pXWIgh+/8rHY7mlUUYTu0PW7rROQd AS/Adxg2UNovTizXzZYYOQdjZyz+2KPbFb1vOh7zFvEu4Q1O9lfM1r3QbcQ39O0ee9swm8 kV2mHhGRN2cD60ptKDW3iZ7cva9Sdun+aYjVufjhqDhKkKuc6fUHmwiQUTm2Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753604504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o7WyYSiwy8q/P1M8aQG3YkzfxkLTWP/jhXLkfJqIusQ=; b=hiM6P9rtEbu/39YXlPKFDtBTATHxVZmTFXbbrOVn2dLEbPBzF8lrBz8Zx8SjiJzpNLDeqR KzdTB+dn2WEiTMXgkhwLu1yt7Wc39hA3ff4sE26ZWqhINz6zEn/rXqeys4m3JkcKnlcjio GAsH9gJSTx90vceYEl5DwZGyTWIJYan4lP5H9+0p7p/XqAqJvfAPbJdqUSJr2FkoBsmHZV A2DfINA6LNmQ5sd8KPttzZSipd9Lo3y0KofQpJsZXMkwgNKXNe5fShfH1m56S61tWfdMl9 7sXHSn9TX5XOOKQy4H3Qu4QuCjlj9ve4U/ljQOyXklotRvcvxEm7bpnNykRCcw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753604504; a=rsa-sha256; cv=none; b=MnQzhqy/DI0PMkPGifTXNJVKV4crCpMPwioCdKyu2VEu/Y2moZv+G+1qO+nIJ2CgX1fd4P K0esCYmhvr1NhqiZiWPVn6ZGTiiEeLDDQ49sI8e+kps0BHFtLgdZBVhglFglqoffHWeuRr Sg6CRkweYu46ujze/gY0TXLi0jN1Ifti2A7WkBvy0/Ox74PsOx6XwxZgAr6JOjboe5id7K pm8vb6xu8tjZ7IILfziTk2Ckh2I7Kko9ALaLY7uqxbeLosehvznbNf4Pi47t4vMDL+WO3+ mxOY5NPC3wQVs98U0iZk948C6ZAMNTeCvSa1dt776fxnO2L4jXwpKPJ5eRoyEQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bqZMX4xyCz16rr; Sun, 27 Jul 2025 08:21:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56R8LiOS091973; Sun, 27 Jul 2025 08:21:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56R8LiUL091970; Sun, 27 Jul 2025 08:21:44 GMT (envelope-from git) Date: Sun, 27 Jul 2025 08:21:44 GMT Message-Id: <202507270821.56R8LiUL091970@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 9b3055d0d4bc - main - src.opts.mk: Default LLVM_ASSERTIONS off List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9b3055d0d4bcbe665d3c622c761adcc7d0a5b1c9 Auto-Submitted: auto-generated The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=9b3055d0d4bcbe665d3c622c761adcc7d0a5b1c9 commit 9b3055d0d4bcbe665d3c622c761adcc7d0a5b1c9 Author: Kevin Bowling AuthorDate: 2025-07-27 08:00:39 +0000 Commit: Kevin Bowling CommitDate: 2025-07-27 08:00:39 +0000 src.opts.mk: Default LLVM_ASSERTIONS off This noticeably slows down the compiler execution and with the move to pkgbase is one of the remaining differences that cannot be administratively controlled; pkg kernels and malloc.conf(5) will allow quickly testing a snapshot in a configuration closer to stable and release branches. dim@ notes that you need to set WITH_LLVM_ASSERTIONS in src.conf(5) if you want to report an issue with LLVM. Enabling WITH_LLVM_ASSERTIONS is also a consideration for CI and pkg builders especially tracking main. Approved by: dim, kevans Differential Revision: https://reviews.freebsd.org/D50388 --- UPDATING | 5 +++++ share/man/man5/src.conf.5 | 7 ++++--- share/mk/src.opts.mk | 2 +- tools/build/options/WITH_LLVM_ASSERTIONS | 1 + 4 files changed, 11 insertions(+), 4 deletions(-) diff --git a/UPDATING b/UPDATING index 8360ab14ada0..611bb62eefcc 100644 --- a/UPDATING +++ b/UPDATING @@ -27,6 +27,11 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 15.x IS SLOW: world, or to merely disable the most expensive debugging functionality at runtime, run "ln -s 'abort:false,junk:false' /etc/malloc.conf".) +20250727: + LLVM's debugging assertions are now disabled in main by default. + The WITH_LLVM_ASSERTIONS src.conf(5) knob should be used to + enable it when working on LLVM or requesting help with it. + 20250726: amd64 kernel configurations must contain "options SMP". diff --git a/share/man/man5/src.conf.5 b/share/man/man5/src.conf.5 index a3db00aed42f..f93d3f9fc69f 100644 --- a/share/man/man5/src.conf.5 +++ b/share/man/man5/src.conf.5 @@ -1,5 +1,5 @@ .\" DO NOT EDIT-- this file is @generated by tools/build/options/makeman. -.Dd July 14, 2025 +.Dd July 27, 2025 .Dt SRC.CONF 5 .Os .Sh NAME @@ -940,8 +940,9 @@ amd64/amd64, arm64/aarch64, i386/i386, powerpc/powerpc64 and powerpc/powerpc64le Do not build the LLD linker during the bootstrap phase of the build. To be able to build the system an alternate linker must be provided via XLD. -.It Va WITHOUT_LLVM_ASSERTIONS -Disable debugging assertions in LLVM. +.It Va WITH_LLVM_ASSERTIONS +Enable debugging assertions in LLVM. +Use when working on or requesting help with LLVM components. .It Va WITHOUT_LLVM_BINUTILS Install ELF Tool Chain's binary utilities instead of LLVM's. This includes diff --git a/share/mk/src.opts.mk b/share/mk/src.opts.mk index ef43d3c939b2..77923ae7b6d1 100644 --- a/share/mk/src.opts.mk +++ b/share/mk/src.opts.mk @@ -123,7 +123,6 @@ __DEFAULT_YES_OPTIONS = \ LEGACY_CONSOLE \ LLD \ LLD_BOOTSTRAP \ - LLVM_ASSERTIONS \ LLVM_BINUTILS \ LLVM_COV \ LLVM_CXXFILT \ @@ -210,6 +209,7 @@ __DEFAULT_NO_OPTIONS = \ HESIOD \ LOADER_VERBOSE \ LOADER_VERIEXEC_PASS_MANIFEST \ + LLVM_ASSERTIONS \ LLVM_FULL_DEBUGINFO \ MALLOC_PRODUCTION \ OFED_EXTRA \ diff --git a/tools/build/options/WITH_LLVM_ASSERTIONS b/tools/build/options/WITH_LLVM_ASSERTIONS index 0e7fbfbda0a3..6af75221a206 100644 --- a/tools/build/options/WITH_LLVM_ASSERTIONS +++ b/tools/build/options/WITH_LLVM_ASSERTIONS @@ -1 +1,2 @@ Enable debugging assertions in LLVM. +Use when working on or requesting help with LLVM components.