Date: Fri, 6 Oct 2017 01:05:57 +0530 From: Ashish SHUKLA <ashish@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r451116 - in head/lang/sagittarius-scheme: . files Message-ID: <875e583e-418b-c26e-0495-87a852548eea@FreeBSD.org> In-Reply-To: <k20c-r1gf-wny@FreeBSD.org> References: <201710030826.v938Q6dt022417@repo.freebsd.org> <k20c-r1gf-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IvSfw4LcUg68oF7QpTDVdGHAXqEQBCBpA Content-Type: multipart/mixed; boundary="lGb0uqXdAEHRFdbDVEEHuLvrGICFvltk6"; protected-headers="v1" From: Ashish SHUKLA <ashish@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <875e583e-418b-c26e-0495-87a852548eea@FreeBSD.org> Subject: Re: svn commit: r451116 - in head/lang/sagittarius-scheme: . files References: <201710030826.v938Q6dt022417@repo.freebsd.org> <k20c-r1gf-wny@FreeBSD.org> In-Reply-To: <k20c-r1gf-wny@FreeBSD.org> --lGb0uqXdAEHRFdbDVEEHuLvrGICFvltk6 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/03/2017 15:35, Jan Beich wrote: > Ashish SHUKLA <ashish@FreeBSD.org> writes: >=20 >> Author: ashish >> Date: Tue Oct 3 08:26:06 2017 >> New Revision: 451116 >> URL: https://svnweb.freebsd.org/changeset/ports/451116 >> >> Log: >> - Update to 0.8.7 >> - Add SIMD option (off by default) to control compilation with SIMD >> flags >> - Add program to generate cpuinfo required for SIMD support detectio= n > [...] >> ++ ELSEIF(CMAKE_SYSTEM_NAME MATCHES "FreeBSD") >> ++ EXEC_PROGRAM(%%CPUID%% OUTPUT_VARIABLE CPUINFO) >> ++ >> ++ STRING(REGEX REPLACE "^.*,(SSE2).*$" "\\1" SSE_THERE ${CPUINFO}= ) >> ++ STRING(COMPARE EQUAL "SSE2" "${SSE_THERE}" SSE2_TRUE) >> ++ IF (SSE2_TRUE) >> ++ set(SSE2_FOUND true CACHE BOOL "SSE2 available on host") >> ++ ELSE (SSE2_TRUE) >> ++ set(SSE2_FOUND false CACHE BOOL "SSE2 available on host") >> ++ ENDIF (SSE2_TRUE) > [...] >> IF (USE_SSE) >> IF (SSE2_FOUND) >> SET(CMAKE_C_FLAGS "-msse2 ${CMAKE_C_FLAGS}") >> SET(CMAKE_CXX_FLAGS "-msse2 ${CMAKE_CXX_FLAGS}") >> ENDIF() >=20 > Given the lack of __SSE*__ guards in the source -m* flags look like a > cargo cult optimization or a verbose way to say CFLAGS +=3D -march=3Dna= tive. > For one, users with CPUTYPE set via make.conf already have -march=3D wh= ich > enables -m* flags supported by the specific CPU. >=20 Indeed, although I'm here just trying to fix, what upstream author was expecting. Thanks! --=20 Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0 --lGb0uqXdAEHRFdbDVEEHuLvrGICFvltk6-- --IvSfw4LcUg68oF7QpTDVdGHAXqEQBCBpA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE9oLNzDncD+rhFiC2x0bPqedPpLAFAlnWiaEACgkQx0bPqedP pLAvxQ//dwGsm01NUVYYmaWDhokKXQBQGbHTStuVtVgGv7rI1IPAWCrtRWHTQ4Ik aX+rWnTE1OlRs8IUg0huzoD2NzPGPop7SoOgPIcMH3siDHVK2oJlNsiO2S2orpvK PE070WmUwG4NK+QhgW9xhHkBYXt5Gg+Ik4KVLJzPLk4KDBse7iqpc06PiM3GkVkd iF352gfjSUQgchX1q7+E1DfDCLCNLT1GGNBBNFrxUx6L5uBi82j1VFx21SEhkfRN SX5EmLd8UghUBmRMJfoeM4em23Ky7vF0yqYe/CBrJz0vqlgxvG3J/luYUoM0aZzE MctEbyPQbjCsDrjosc54rMw5Z9Xa9igo209H3D+vtKh567+pSJRp3Hc8htJpEHJt vHxx3TjFI9Q4cmg0ut9C9ebNt+I2rty1QGZq/+r9DBrYzEzS+WV3Ddh1FcNPF5jP uSaCB8poVIv/L0APsqo4+P/u5dJFU/Agru2gjYBpBBzy9HFL02mEIvobnM93qkt6 Ja7tqcvBSorVCu2o8rh5JEI15Tj/7nAvg2ae3lMSSCKzuyjjQl9Ukcyy6D9ySEK1 5Q/PKaHbC2bAOy4DCWmbfL/B4vXRhipA6EP1/uPvvkQN0KRfUJwv43GlrkcEpotm zRaUlFW9zahTmSAXhTZxhUhz6CxJFfdIkgxEKQ6EH2227B95F2Y= =ExZ/ -----END PGP SIGNATURE----- --IvSfw4LcUg68oF7QpTDVdGHAXqEQBCBpA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?875e583e-418b-c26e-0495-87a852548eea>