From owner-cvs-all@FreeBSD.ORG Sat Oct 6 20:14:31 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 856E816A565 for ; Sat, 6 Oct 2007 20:14:31 +0000 (UTC) (envelope-from erikt@midgard.homeip.net) Received: from ch-smtp01.sth.basefarm.net (ch-smtp01.sth.basefarm.net [80.76.149.212]) by mx1.freebsd.org (Postfix) with ESMTP id 166F113C586 for ; Sat, 6 Oct 2007 20:14:29 +0000 (UTC) (envelope-from erikt@midgard.homeip.net) Received: from c83-253-31-60.bredband.comhem.se ([83.253.31.60]:60340 helo=falcon.midgard.homeip.net) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.66) (envelope-from ) id 1IeG2d-0007ES-6N for cvs-all@freebsd.org; Sat, 06 Oct 2007 22:14:28 +0200 Received: (qmail 3697 invoked from network); 6 Oct 2007 22:07:43 +0200 Received: from owl.midgard.homeip.net (10.1.5.7) by falcon.midgard.homeip.net with ESMTP; 6 Oct 2007 22:07:43 +0200 Received: (qmail 36428 invoked by uid 1001); 6 Oct 2007 22:07:43 +0200 Date: Sat, 6 Oct 2007 22:07:43 +0200 From: Erik Trulsson To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Message-ID: <20071006200743.GA24686@owl.midgard.homeip.net> Mail-Followup-To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= , Scott Long , Jack F Vogel , cvs-src@freebsd.org, src-committers@freebsd.org, Jack Vogel , cvs-all@freebsd.org References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> <20071005231538.GA24016@owl.midgard.homeip.net> <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> <20071006004634.GA24962@owl.midgard.homeip.net> <47073AF5.1010109@samsco.org> <86d4vspk8j.fsf@ds4.des.no> <47079A5C.3090109@samsco.org> <86odfcvx3x.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <86odfcvx3x.fsf@ds4.des.no> User-Agent: Mutt/1.5.16 (2007-06-09) X-Originating-IP: 83.253.31.60 X-Scan-Result: No virus found in message 1IeG2d-0007ES-6N. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1IeG2d-0007ES-6N cdc66e2edd6b9685edb8c6afe9ddf428 Cc: Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Jack Vogel , Jack F Vogel Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 20:14:31 -0000 On Sat, Oct 06, 2007 at 09:53:06PM +0200, Dag-Erling Sm=F8rgrav wrote: > Scott Long writes: > > Dag-Erling Sm=F8rgrav writes: > > > We used to have a principle that commit bits were granted to individu= als > > > on their individual merit, not simply because they represented a vend= or > > > and were paid to work on drivers for that vendor's hardware. > > Are you implying that Jack has no merit? That's an unfortunate > > assertion. What evidence do you have to support that? >=20 > It is you who implied rather strongly that Jack is neither more nor less > than an Intel representative. You spoke of "lecturing a vendor" when > all Erik did was point out or own rules to a *committer*. >=20 > > > We also used to have a principle that changes should be tested > > > before being committed, especially to -STABLE. > > I guess you missed that part where Jack said that the changes had > > undergone extensive testing. >=20 > I guess you missed the part where his commit broke the tinderbox, > because he clearly did not test the DEVICE_POLLING case. In Jack's defense that particular problem was apparently beacuse a 7.x interface was left in the code (bus_setup_intr(9) takes one more argument in 7.x than it does in 6.x.) That would not have been caught by having the code go into -CURRENT first. --=20 Erik Trulsson ertr1013@student.uu.se