From owner-svn-src-user@FreeBSD.ORG Tue Mar 10 21:43:18 2009 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 038131065677 for ; Tue, 10 Mar 2009 21:43:18 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with ESMTP id 85AAD8FC1D for ; Tue, 10 Mar 2009 21:43:17 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 30526 invoked by uid 399); 10 Mar 2009 21:43:12 -0000 Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 10 Mar 2009 21:43:12 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <49B6DEED.4040902@FreeBSD.org> Date: Tue, 10 Mar 2009 14:43:09 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.19 (X11/20090307) MIME-Version: 1.0 To: Luigi Rizzo References: <200903100751.n2A7p02m050724@svn.freebsd.org> <49B6CF13.9060501@FreeBSD.org> <20090310212511.GA53115@onelab2.iet.unipi.it> In-Reply-To: <20090310212511.GA53115@onelab2.iet.unipi.it> X-Enigmail-Version: 0.95.7 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Lawrence Stewart , src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r189612 - in user/lstewart/alq_varlen_8.x: sys/kern tools/test/alq X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2009 21:43:18 -0000 Luigi Rizzo wrote: > On Tue, Mar 10, 2009 at 01:35:31PM -0700, Doug Barton wrote: >> Lawrence Stewart wrote: >>> Author: lstewart >>> Date: Tue Mar 10 07:50:59 2009 >>> New Revision: 189612 >>> URL: http://svn.freebsd.org/changeset/base/189612 >>> >>> Log: >>> More bug and style fixes. >> Generally it's preferred not to mix these two types of changes. The >> preferred course of action is to make the style changes, confirm that >> the binary is unchanged (e.g., with sha256), then do substantive >> changes. Makes the revision history a little easier to parse down the >> road. > > well, this is a private branch after all :) 1. Good habits come from good practice, and what better place to practice than in a "private" branch? 2. Given that the stuff is in the FreeBSD repository, the presumption is that it is of some use to the wider FreeBSD community. So IMO community best practices are a reasonable expectation. Otherwise, why not just keep it local? Doug -- This .signature sanitized for your protection