Date: Sat, 2 Dec 2006 23:54:44 +0000 From: RW <fbsd06@mlists.homeunix.com> To: freebsd-questions@freebsd.org Subject: Re: pkgtools.conf error with portmanager Message-ID: <200612022354.45162.fbsd06@mlists.homeunix.com> In-Reply-To: <457208D3.1010508@u.washington.edu> References: <20061202074631.S84600@scorpio.seibercom.net> <200612022152.14049.fbsd06@mlists.homeunix.com> <457208D3.1010508@u.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 02 December 2006 23:14, Garrett Cooper wrote:
> RW wrote:
> > On Saturday 02 December 2006 21:26, Garrett Cooper wrote:
> >> RW wrote:
> >>> My patch file is below.
> >>>
> >>> $ cd /usr/ports/sysutils/portmanager/ && cat
> >>> files/patch-no-ruby-support --- libMGPM/src/MGPMrReadConfigure.c.orig
> >>> Sat Dec 2 17:10:45 2006 +++ libMGPM/src/MGPMrReadConfigure.c
> >>> Sat Dec 2 17:11:37 2006 @@ -190,9 +190,7 @@
> >>> MGmStrcpy( portupgradeFileName, PREFIXDIR );
> >>> MGmStrcat( portupgradeFileName, "/sbin/portupgrade" );
> >>>
> >>> - if( MGrIfFileExist( rubyFileName ) &&
> >>> - MGrIfFileExist( pkgtoolsFileName ) &&
> >>> - MGrIfFileExist( portupgradeFileName ) )
> >>> + if( 0 )
> >>> {
> >>> /*
> >>> * run ruby script
> >>
> >> I assume ruby follows the same conventions as many other procedural
> >> languages ( 0 is false, non-0 is true).
> >
> > I've no idea about ruby, the patch is to MGPMrReadConfigure.c
> >
> >> If so, why are you preventing
> >> the lines below if( 0 ) from running in your patch given above? Might as
> >> well comment out or delete the following lines because they won't be
> >> evaluated and run..
> >
> > True, but that would be more effort, so I might as well not; and keeping
> > it simple reduces the chance of a conflict with a future patch. And it's
> > not as if anyone is ever going to permanently integrate this patch into
> > the source files.
>
> You do realize portupgrade is ruby based though, do you not?
Yes, I do, but I'm patching portmanager, not portupgrade.
Portmanager is written in C
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612022354.45162.fbsd06>