Date: Sat, 30 Apr 2016 09:32:19 +0000 (UTC) From: Garrett Cooper <ngie@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r298842 - head/lib/libkvm Message-ID: <201604300932.u3U9WJDd057613@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ngie Date: Sat Apr 30 09:32:19 2016 New Revision: 298842 URL: https://svnweb.freebsd.org/changeset/base/298842 Log: Don't leak PML4 in _amd64_initvtop(..) if kvm_read2(..) fails MFC after: 1 week Reported by: Coverity CID: 1341474 Sponsored by: EMC / Isilon Storage Division Modified: head/lib/libkvm/kvm_amd64.c Modified: head/lib/libkvm/kvm_amd64.c ============================================================================== --- head/lib/libkvm/kvm_amd64.c Sat Apr 30 09:31:01 2016 (r298841) +++ head/lib/libkvm/kvm_amd64.c Sat Apr 30 09:32:19 2016 (r298842) @@ -159,6 +159,7 @@ _amd64_initvtop(kvm_t *kd) } if (kvm_read2(kd, pa, PML4, AMD64_PAGE_SIZE) != AMD64_PAGE_SIZE) { _kvm_err(kd, kd->program, "cannot read KPML4phys"); + free(PML4); return (-1); } kd->vmst->PML4 = PML4;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604300932.u3U9WJDd057613>