From owner-cvs-ports  Wed Nov 20 04:27:23 1996
Return-Path: owner-cvs-ports
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id EAA28639
          for cvs-ports-outgoing; Wed, 20 Nov 1996 04:27:23 -0800 (PST)
Received: from dfw-ix7.ix.netcom.com (dfw-ix7.ix.netcom.com [206.214.98.7])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id EAA28630;
          Wed, 20 Nov 1996 04:27:21 -0800 (PST)
Received: from silvia.HIP.Berkeley.EDU (ala-ca8-35.ix.netcom.com [207.93.141.163]) by dfw-ix7.ix.netcom.com (8.6.13/8.6.12) with ESMTP id EAA10795; Wed, 20 Nov 1996 04:26:46 -0800
Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.8.2/8.6.9) id EAA02157; Wed, 20 Nov 1996 04:26:43 -0800 (PST)
Date: Wed, 20 Nov 1996 04:26:43 -0800 (PST)
Message-Id: <199611201226.EAA02157@silvia.HIP.Berkeley.EDU>
To: torstenb@pegasus.tlk.com
CC: torstenb@freefall.freebsd.org, CVS-committers@freefall.freebsd.org,
        cvs-all@freefall.freebsd.org, cvs-ports@freefall.freebsd.org
In-reply-to: <m0vPqjL-000mBEC@pegasus.tlk.com> (torstenb@pegasus.tlk.com)
Subject: Re: cvs commit:  ports/games/imaze Makefile ports/games/imaze/patches patch-ab patch-aa
From: asami@freebsd.org (Satoshi Asami)
Sender: owner-cvs-ports@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

 * > (1) Checking MOTIFLIB here is meaningless, many users won't have it
 * >     defined even if they have Motif.  (HAVE_MOTIF will define MOTIFLIB
 * >     it in bsd.port.mk, which is included after this line.)
 * 
 * ok, optional now.

You misunderstood me.  I said CHECKING it here is meaningless, because 
it's typically undefined for both Motif users and non-Motif users.
You added a definition of this, which is totally bogus.

 * > (2) We don't want to ship static Motif libraries if the port can be
 * >     compiled with other toolkits.
 * >
 * > 
 * > >From the above two, I think it's better if you check if
 * > defined(HAVE_MOTIF) and !defined(MOTIF_STATIC).
 * 
 * Hm, we don't have to link imaze with motif. It works with xview and that's
 * still the default.

It's ok to build it with Motif if the user has shared libXm and
intends to use it with only shared libXm.

Satoshi