From nobody Thu Sep 18 08:51:59 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cS8X03lLhz681fq; Thu, 18 Sep 2025 08:52:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cS8Wz6BTjz3hm1; Thu, 18 Sep 2025 08:51:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758185519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n9LLqXq9/UfjqvhBDw6paIYwB9Q2DohngxXjMAsPj6Y=; b=hVWPNbH760oee9ynS7d/jwxSZ55R9xRsY6noxyKnYaUG2j5VIF3O2yvVvXfSE9cPffP8mF zDfQezX4Z4zZOqqPmkjVYoRJASiegV7JaxLS7W+Qg2SI1MTNfqoqwMHVmIqhqW7z+N0LLg bc+ODs35QsAge1LdZRo7haTtONFMVnzN0Rzdh92l6rBz95IrgJs+MnKsMOmWL4t9kWi+RK iiQdNLLQremJtq4c6nlo6GB/dKFGXu+CUKmUo30g4qT8LIhB2P0ITqLxSWmtZo2SPNHYmF tpwokd2Sr7BbRIGrjhi4X6wN3GGGeMS9ILEv8rNOADkNX564Qw5BihBsJTuj4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758185519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n9LLqXq9/UfjqvhBDw6paIYwB9Q2DohngxXjMAsPj6Y=; b=pVXxHcTTdrIndgTH36OYRp/vOmIiSFES22vnMMnT6EIBlGBtu/xEQJUqOLFR4lVyFjH1PV qsScBcKtd82aQGH7s2vVamLo+pyGENm2yDTjnpvZIsqk4ODVAGPoZNYj5/9ElMSRr2w52+ TK0j0nYxzZISM8soz67QnhSEl5steLkT2wiqB5eF7lyi1BwPmqZXfUD8pApvW/L3RKpAh/ pi0JWKWz0szEVCUkuDkT9fymHLmlB0yECtToH5VIDC+y31NAncschYjBxZus2TfI1OlES3 vdHlm/tFTRP817fC7TumXkupfbyjdDM2my2Ew1xieuCpjb6h9ivM3KmvaPXMhw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758185519; a=rsa-sha256; cv=none; b=hYvqRIolEU97Ysq+E/vqPB5gZ0CfAuL2dMcpimp7T4/RBdUAymv+t6+QdesopJ7K91BaS4 Z2iIX0Ops3x3n/H7xofxcPYioEdW9nrSin+1gIA6XgUtsePu0Ew4rXWhfR0a+Jpfs8lfOZ XoVWXjCCqgTy2UYuFfmptLq+zq9drzrxWocnw5Z3lJNbfwqFyUm5L8T6y9CTZk4T+xoKqv fZ0i0x7gNw1iqjjoGaxB1AutjiYRDb+E5AaBV1+ySIe7Anz93QZjWNTFpM9C0WfxW1OtXg rIgHkc49BQj6iF0HAJbSpfc9v2P722pJA83WuJwt1K+5B7CsHjfLf/p/5JtteQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cS8Wz5jhwz14bG; Thu, 18 Sep 2025 08:51:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58I8pxEr017404; Thu, 18 Sep 2025 08:51:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58I8pxTl017401; Thu, 18 Sep 2025 08:51:59 GMT (envelope-from git) Date: Thu, 18 Sep 2025 08:51:59 GMT Message-Id: <202509180851.58I8pxTl017401@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: a5e6ecb88986 - stable/15 - nfs: newnfs_setroot(): Remove an obsolete comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: a5e6ecb88986399a0d06f41404e6dc16bc11f698 Auto-Submitted: auto-generated The branch stable/15 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=a5e6ecb88986399a0d06f41404e6dc16bc11f698 commit a5e6ecb88986399a0d06f41404e6dc16bc11f698 Author: Olivier Certner AuthorDate: 2025-08-26 10:26:36 +0000 Commit: Olivier Certner CommitDate: 2025-09-18 08:50:29 +0000 nfs: newnfs_setroot(): Remove an obsolete comment This comment is obsolete, as: 1. This code is FreeBSD-specific and is not shared with other BSDs. 2. With our recent changes in commit be1f7435ef218b1d ("kern: start tracking cr_gid outside of cr_groups[]"), all of NetBSD, OpenBSD and FreeBSD have the effective GID in a separate field (DragonFlyBSD remains to this day an outlier). MFC after: 9 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52254 (cherry picked from commit 67f8bd5986a42a173ef9082abfcd523b1a3ac056) --- sys/fs/nfs/nfs_commonport.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/fs/nfs/nfs_commonport.c b/sys/fs/nfs/nfs_commonport.c index e5fdb395c9f7..862780741ee7 100644 --- a/sys/fs/nfs/nfs_commonport.c +++ b/sys/fs/nfs/nfs_commonport.c @@ -371,8 +371,6 @@ nfsrv_atroot(struct vnode *vp, uint64_t *retp) /* * Set the credentials to refer to root. - * If only the various BSDen could agree on whether cr_gid is a separate - * field or cr_groups[0]... */ void newnfs_setroot(struct ucred *cred)