From owner-freebsd-arch@FreeBSD.ORG Thu Jun 2 01:49:08 2005 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A402716A41C for ; Thu, 2 Jun 2005 01:49:08 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2EB2B43D1F for ; Thu, 2 Jun 2005 01:49:08 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout2.pacific.net.au (8.12.3/8.12.3/Debian-7.1) with ESMTP id j521mqkG018327; Thu, 2 Jun 2005 11:48:52 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.12.3/8.12.3/Debian-7.1) with ESMTP id j521mmMC028324; Thu, 2 Jun 2005 11:48:50 +1000 Date: Thu, 2 Jun 2005 11:48:49 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Xin LI In-Reply-To: <20050601134351.GA76097@frontfree.net> Message-ID: <20050602114323.R98072@delplex.bde.org> References: <1117613456.771.16.camel@spirit> <20050601211628.V96009@delplex.bde.org> <20050601134351.GA76097@frontfree.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: delphij@delphij.net, freebsd-arch@freebsd.org Subject: Re: [PATCH RFC] Add a macro for null mount options to sbin/mount* X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2005 01:49:08 -0000 On Wed, 1 Jun 2005, Xin LI wrote: > On Wed, Jun 01, 2005 at 09:23:23PM +1000, Bruce Evans wrote: >> >> MOPT_NULL is a poor name. It is not a null option, but a terminator that >> happens to have nulls in it. > > Agreed... Will the patch found in attachment look better? It also > updates the manpage. The name is OK now, but see other replies about the changes obfuscating the terminating condition. % Index: mount/mntopts.h % =================================================================== % RCS file: /home/ncvs/src/sbin/mount/mntopts.h,v % retrieving revision 1.25 % diff -u -r1.25 mntopts.h % --- mount/mntopts.h 1 Jun 2005 09:39:34 -0000 1.25 % +++ mount/mntopts.h 1 Jun 2005 13:35:57 -0000 % @@ -66,7 +66,7 @@ % #define MOPT_AUTO { "auto", 0, 0, 0 } % % /* A handy macro as terminator of MNT_ array */ The previous patch also has some style bugs. I noticed mainly the missing sentence (fragment) termination here. All other sentence (fragment)s in comments in this file except ones to the right of code are terminated normally. Bruce