From owner-cvs-src@FreeBSD.ORG Mon Apr 14 17:35:13 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09BB9106566B; Mon, 14 Apr 2008 17:35:13 +0000 (UTC) (envelope-from remko@elvandar.org) Received: from websrv01.jr-hosting.nl (websrv01.jr-hosting.nl [78.47.69.233]) by mx1.freebsd.org (Postfix) with ESMTP id BFA628FC2C; Mon, 14 Apr 2008 17:35:12 +0000 (UTC) (envelope-from remko@elvandar.org) Received: from [195.64.94.120] (helo=axantucar.local) by websrv01.jr-hosting.nl with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69 (FreeBSD)) (envelope-from ) id 1JlSaY-0007CW-Id; Mon, 14 Apr 2008 19:35:30 +0200 Message-ID: <480395C8.5010003@elvandar.org> Date: Mon, 14 Apr 2008 19:35:04 +0200 From: Remko Lodder User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213) MIME-Version: 1.0 To: pyunyh@gmail.com References: <968902.70296.qm@web33708.mail.mud.yahoo.com> <20080414010849.GF15616@cdnetworks.co.kr> In-Reply-To: <20080414010849.GF15616@cdnetworks.co.kr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Abdullah Ibn Hamad Al-Marri Subject: Re: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Apr 2008 17:35:13 -0000 Pyun YongHyeon wrote: > On Wed, Apr 09, 2008 at 12:34:01PM -0700, Abdullah Ibn Hamad Al-Marri wrote: > > ----- Original Message ---- > > > From: Pyun YongHyeon > > > To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; cvs-all@FreeBSD.org > > > Sent: Monday, March 31, 2008 7:03:14 AM > > > Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h > > > > > > yongari 2008-03-31 04:03:14 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/re if_re.c > > > sys/pci if_rlreg.h > > > Log: > > > Padding more bytes than necessary one broke another variants of > > > PCIe RealTek chips. Only pad IP packets if the payload is less than > > > 28 bytes. > > > > > > Obtained from: NetBSD > > > PR: kern/122221 > > > > > > Revision Changes Path > > > 1.113 +1 -1 src/sys/dev/re/if_re.c > > > 1.74 +6 -0 src/sys/pci/if_rlreg.h > > > > Hello Pyun, > > > > I hope you are doing well. > > > > This is a friendly reminder... > > > > It has been more than a week since you said you'll MFC the re changes to RELENG_7 > > > > I still suffer of the current patch and the re poor performance. > > > > Thank you in advance, > > > > There was one regression report from remko so we are testing a patch. > It seems that the regression is hard to reproduce at will it may > take more time. I'll MFC all changes to RELENG_7 as soon as he say Ok. > > Thanks for remiding this! Hi all, I think Pyun can MFC the changes where needed / possible because I couldn't trigger it so far. Last time it took me several days to get the machine down, so one never knows when I can reproduce it again. I am getting a new (Second) machine to test this with somewhere this week so that I can 'dedicatedly' test the patch and try to reproduce it even quicker :-) That said; I think the changes made by pyun are a substantial improvement nevertheless and should (Where possible) not be withheld from people :) Pyun please process this when possible :-) Cheers remko -- /"\ Best regards, | remko@FreeBSD.org \ / Remko Lodder | remko@EFnet X http://www.evilcoder.org/ | / \ ASCII Ribbon Campaign | Against HTML Mail and News