From owner-svn-ports-head@freebsd.org  Fri Sep 20 12:29:09 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2E0FDFC0B3;
 Fri, 20 Sep 2019 12:29:09 +0000 (UTC) (envelope-from osa@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 46ZY1K0RHCz474V;
 Fri, 20 Sep 2019 12:29:09 +0000 (UTC) (envelope-from osa@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 975)
 id E2B585C78; Fri, 20 Sep 2019 12:29:08 +0000 (UTC)
Date: Fri, 20 Sep 2019 12:29:08 +0000
From: "Sergey A. Osokin" <osa@freebsd.org>
To: "Herbert J. Skuhra" <herbert@gojira.at>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r512184 - in head/www/nginx-devel: . files
Message-ID: <20190920122908.GG12076@FreeBSD.org>
References: <201909162038.x8GKcLoD070077@repo.freebsd.org>
 <87v9toaxaq.wl-herbert@gojira.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <87v9toaxaq.wl-herbert@gojira.at>
User-Agent: Mutt/1.11.4 (2019-03-13)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Sep 2019 12:29:09 -0000

On Thu, Sep 19, 2019 at 09:41:33PM +0200, Herbert J. Skuhra wrote:
> On Mon, 16 Sep 2019 22:38:21 +0200, "Sergey A. Osokin" wrote:
> > 
> > Author: osa
> > Date: Mon Sep 16 20:38:21 2019
> > New Revision: 512184
> > URL: https://svnweb.freebsd.org/changeset/ports/512184
> > 
> > Log:
> >   Add the following third-party modules:
> >   o) ip2location
> >   o) ip2proxy
> >   
> >   Add third-party slice_ahead feature.
> >   
> >   Update third-party passenger module to the latest release 6.0.3.
> >   
> >   Switch third-party lua module dependence from lang/luajit (2.0) to
> >   lang/luajit-openresty (2.1).
> >   
> >   Bump PORTREVISION.
> > 
> > Modified:
> >   head/www/nginx-devel/Makefile
> >   head/www/nginx-devel/Makefile.extmod
> >   head/www/nginx-devel/Makefile.options.desc
> >   head/www/nginx-devel/distinfo
> >   head/www/nginx-devel/files/extra-patch-passenger-build-nginx.rb
> >   head/www/nginx-devel/files/extra-patch-passenger-disable-telemetry
> 
> This commit is obviously wrong/incomplete:
> 
> 1. option HTTP_SLICE_AHEAD was added in wrong place
> 2. extra-patch-src_http_modules_ngx_http_slice_read_ahead.c is missing

Hi Herbert,

thanks for point me in.  The missing patch has been found and added
to the port.
Could you please explain what does it mean HTTP_SLICE_AHEAD in a wrong
place.

Thanks.

--
Sergey