From owner-p4-projects@FreeBSD.ORG  Mon Feb  2 17:54:07 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D6C9F1065673; Mon,  2 Feb 2009 17:54:06 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 96D1A1065670
	for <perforce@freebsd.org>; Mon,  2 Feb 2009 17:54:06 +0000 (UTC)
	(envelope-from antab@valka.is)
Received: from smtp-vbr19.xs4all.nl (smtp-vbr19.xs4all.nl [194.109.24.39])
	by mx1.freebsd.org (Postfix) with ESMTP id 31E8C8FC13
	for <perforce@freebsd.org>; Mon,  2 Feb 2009 17:54:05 +0000 (UTC)
	(envelope-from antab@valka.is)
Received: from dumb.farm.antab.is (farm.antab.is [80.101.60.195])
	by smtp-vbr19.xs4all.nl (8.13.8/8.13.8) with ESMTP id n12HfJX4020632;
	Mon, 2 Feb 2009 18:41:25 +0100 (CET) (envelope-from antab@valka.is)
Message-Id: <2757071E-6E55-43F5-B298-408AFC6793C6@valka.is>
From: Arnar Mar Sig <antab@valka.is>
To: Hans Petter Selasky <hselasky@c2i.net>
In-Reply-To: <200902011247.10404.hselasky@c2i.net>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v930.3)
Date: Mon, 2 Feb 2009 18:41:19 +0100
References: <200902010059.n110xfXx079961@repoman.freebsd.org>
	<49850FB9.9040008@bluezbox.com>
	<200902011247.10404.hselasky@c2i.net>
X-Mailer: Apple Mail (2.930.3)
X-Virus-Scanned: by XS4ALL Virus Scanner
Cc: Arnar Mar Sig <antab@freebsd.org>,
	Perforce Change Reviews <perforce@freebsd.org>,
	Oleksandr Tymoshenko <gonzo@bluezbox.com>
Subject: Re: PERFORCE change 156978 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Feb 2009 17:54:07 -0000

On Feb 1, 2009, at 12:47 PM, Hans Petter Selasky wrote:
> On Sunday 01 February 2009, Oleksandr Tymoshenko wrote:
>> Arnar Mar Sig wrote:
>>> http://perforce.freebsd.org/chv.cgi?CH=156978
>>>
>>> Change 156978 by antab@antab_farm on 2009/02/01 00:58:58
>>>
>>> 	AVR32 support. The kernel boots on NGW100 but there is still alot  
>>> of
>>> work to be done. At the moment it crashes somewhere in uma_startup3.
>>
>>    That's just cool! :) Thanks a lot for your hard work.
>
> Just a small style nit:
>
> Use \t or TAB after "#define" instead of space.
Usually do, but some code is copied between terms and lost \t, coding  
style is also not according style(9) but that will be fixes.

> Looking forward to programming USB support for the AVR32.
Good, but i would like to get some clock framework in place before  
doing any device driver, I really dislike the hardcoded clock speeds  
that are used in in some at91 drivers.

Arnar Mar Sig