From owner-svn-src-head@FreeBSD.ORG  Tue Jan  4 15:59:55 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id B629C1065670
	for <svn-src-head@freebsd.org>; Tue,  4 Jan 2011 15:59:55 +0000 (UTC)
	(envelope-from cperciva@freebsd.org)
Received: from xps.daemonology.net (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx2.freebsd.org (Postfix) with SMTP id 3E16D14E6EC
	for <svn-src-head@freebsd.org>; Tue,  4 Jan 2011 15:59:55 +0000 (UTC)
Received: (qmail 46819 invoked from network); 4 Jan 2011 15:59:55 -0000
Received: from unknown (HELO xps.daemonology.net) (127.0.0.1)
	by localhost with SMTP; 4 Jan 2011 15:59:55 -0000
Message-ID: <4D2343FB.4030402@freebsd.org>
Date: Tue, 04 Jan 2011 07:59:55 -0800
From: Colin Percival <cperciva@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.1.16) Gecko/20101220 Thunderbird/3.0.11
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
References: <201101040016.p040GcNf010998@svn.freebsd.org>
	<201101040800.45155.jhb@freebsd.org>
In-Reply-To: <201101040800.45155.jhb@freebsd.org>
X-Enigmail-Version: 1.0.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r216944 - head/sys/i386/xen
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Jan 2011 15:59:55 -0000

On 01/04/11 05:00, John Baldwin wrote:
> On Monday, January 03, 2011 7:16:38 pm Colin Percival wrote:
>> +#ifdef INVARIANTS
>>  	if (__predict_true(gdtset))
>> -		critical_enter();
>> +		KASSERT(curthread->td_critnest > 0,
>> +		    ("xen queue flush should be in a critical section"));
>> +#endif
>> +
> 
> You can use CRITICAL_ASSERT(curthread) instead perhaps.

Duh.  I was looking for that but somehow didn't feed the right keywords to grep.

Thanks!

-- 
Colin Percival
Security Officer, FreeBSD | freebsd.org | The power to serve
Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid