From owner-svn-src-all@freebsd.org Wed Aug 21 07:59:08 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C7340BE72D; Wed, 21 Aug 2019 07:59:08 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46D0Rc4nvpz4dBN; Wed, 21 Aug 2019 07:59:08 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f48.google.com with SMTP id i22so2800096ioh.2; Wed, 21 Aug 2019 00:59:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=xeV9Rl8I/2RO3xcFmWHHdmOZfSGRYwVGIFBnr4sw28Y=; b=d3akbUcrDiAtNAZzo4nmnN3HAisovvbqzHn4FkuXiU2htfr0CuIlq3xSXSEKUcnaL8 tOmbmjSetq3UObOcZcsVNvKy/Ua38OJC/H76x2p+9xDhqygIj9S5DTLSN2OtGlnfb0Bu WiyjGDmtaBbTS/tSaFAsxFY33JZLbYkvywRbHx4o0qSjk7N+PW/j8nuiV2ERes8eOdfd CgQcDfrfNAJwYgoLqQPWA/zyFbpnZCCugcpesHFE5ufi3xxx+qrxRyxOeSCmczs9TyQZ UIDpB7TpFOyreZ/lzDn/tLI6QKQ7qk3xTU3xw2Z/zxZIbyFTzerNRTsS3lk6+dB8KoWs m/sg== X-Gm-Message-State: APjAAAVkjSV4yVMiOr2ao/E1lWkC0gXiuWa98wRdTsqFAEl6UK0dlOjP wXcQY2nP1nrQGjn2UbH/agoFlPiP X-Google-Smtp-Source: APXvYqzLk/aeVipYekTC2aCbA3AHhUAmUW9GiJppihpJGq5lHr3f12BkHhQlV+zqbLBmrWMP76xRrQ== X-Received: by 2002:a5e:9701:: with SMTP id w1mr4883879ioj.294.1566374347247; Wed, 21 Aug 2019 00:59:07 -0700 (PDT) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com. [209.85.166.46]) by smtp.gmail.com with ESMTPSA id j16sm19614739iok.34.2019.08.21.00.59.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2019 00:59:06 -0700 (PDT) Received: by mail-io1-f46.google.com with SMTP id t3so2683837ioj.12; Wed, 21 Aug 2019 00:59:06 -0700 (PDT) X-Received: by 2002:a6b:f216:: with SMTP id q22mr35767399ioh.65.1566374346744; Wed, 21 Aug 2019 00:59:06 -0700 (PDT) MIME-Version: 1.0 References: <201908210745.x7L7jd30086482@repo.freebsd.org> In-Reply-To: <201908210745.x7L7jd30086482@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Wed, 21 Aug 2019 00:58:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r351324 - head/sys/netgraph/bluetooth/drivers/ubt To: Xin LI Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46D0Rc4nvpz4dBN X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Aug 2019 07:59:08 -0000 Hi Xin Li, On Wed, Aug 21, 2019 at 12:45 AM Xin LI wrote: > URL: https://svnweb.freebsd.org/changeset/base/351324 > > Log: > The 'mtx' is on stack and can contain garbages that would cause mtx_init > (and in turn lock_init) to think that the mutex was already initialized. > > --- head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c Wed Aug 21 04:54:48 2019 (r351323) > +++ head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c Wed Aug 21 07:45:39 2019 (r351324) > @@ -554,6 +554,7 @@ ubt_do_hci_request(struct usb_device *udev, struct ubt > /* Initialize INTR endpoint xfer and wait for response */ > + bzero(&mtx, sizeof(mtx)); > mtx_init(&mtx, "ubt pb", NULL, MTX_DEF); This is usually spelled 'MTX_DEF | MTX_NEW' instead. Best regards, Conrad