From owner-cvs-all@FreeBSD.ORG  Thu Jun  5 03:00:26 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5330437B401; Thu,  5 Jun 2003 03:00:26 -0700 (PDT)
Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua
	[212.110.138.65])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 79F7743FA3; Thu,  5 Jun 2003 03:00:21 -0700 (PDT)
	(envelope-from ru@whale.sunbay.crimea.ua)
Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1])
	h55A07Ed044688
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 5 Jun 2003 13:00:16 +0300 (EEST)
	(envelope-from ru@whale.sunbay.crimea.ua)
Received: (from ru@localhost)
	by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h55A07sY044683;
	Thu, 5 Jun 2003 13:00:07 +0300 (EEST)
	(envelope-from ru)
Date: Thu, 5 Jun 2003 13:00:07 +0300
From: Ruslan Ermilov <ru@FreeBSD.org>
To: Marcel Moolenaar <marcel@FreeBSD.org>
Message-ID: <20030605100007.GA42986@sunbay.com>
References: <200306040517.h545HIY1051372@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW"
Content-Disposition: inline
In-Reply-To: <200306040517.h545HIY1051372@repoman.freebsd.org>
User-Agent: Mutt/1.5.4i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/release Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jun 2003 10:00:26 -0000


--ew6BAiZeqk4r7MaW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 03, 2003 at 10:17:18PM -0700, Marcel Moolenaar wrote:
> marcel      2003/06/03 22:17:18 PDT
>=20
>   FreeBSD src repository
>=20
>   Modified files:
>     release              Makefile=20
>   Log:
>   Have the port readmes follow the same logic as buildworld. We skip
>   doing make readmes if /tmp/.skip_ports exists. This file is created
>   after a complete run, which avoids that we do the lengthy operation
>   again for a rerelease.
>   When NOPORTS or NOPORTREADMES are defined, we create the file prior
>   to starting the release.
>  =20
>   Revision  Changes    Path
>   1.781     +5 -5      src/release/Makefile
>=20
I think this is not quite right.  Instead, the /tmp/.ports_done
should be created, similar to /tmp/.world_done, when ports are
really done.

When NOPORTS or NOPORTREADMES are defined, we should just not be
doing the relevant parts of "make release".  And of course, it
should be possible to run "make -DNOPORTS release" first, and be
able to run "make rerelease" later, and get the ports built.

What do you think?


Cheers,
--=20
Ruslan Ermilov		Sysadmin and DBA,
ru@sunbay.com		Sunbay Software Ltd,
ru@FreeBSD.org		FreeBSD committer

--ew6BAiZeqk4r7MaW
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQE+3xSmUkv4P6juNwoRAhpzAJwKJYl6BNTwJTo+cJW5QBAKKGgKxQCgi86W
gqW43bSDAtDHISd6IFCR16c=
=pIk6
-----END PGP SIGNATURE-----

--ew6BAiZeqk4r7MaW--