Date: Tue, 12 Jul 2022 06:37:57 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Matthias Fechner <mfechner@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4671249405c0 - main - net/rubygem-omniauth-auth0: Fix build failure Message-ID: <CAMHz58TnfW0H4X_iKseaa-y1M68q0Ea0XXNKUtngBS0fNvAiZw@mail.gmail.com> In-Reply-To: <e3534f11-5199-d7a4-b651-02978dfb667c@FreeBSD.org> References: <202206301432.25UEWIi4077084@gitrepo.freebsd.org> <CAMHz58SnxZExPOADE4NZFDvKJD=w-mtJ1vbvVJHDvXcVw7X_Vw@mail.gmail.com> <e3534f11-5199-d7a4-b651-02978dfb667c@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000045e9fc05e38f369c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 6, 2022 at 11:31 PM Matthias Fechner <mfechner@freebsd.org> wrote: > Dear Sunpoet, > > Am 06.07.2022 um 16:35 schrieb Po-Chuan Hsieh: > > On Thu, Jun 30, 2022 at 10:32 PM Matthias Fechner <mfechner@freebsd.org> > wrote: > >> The branch main has been updated by mfechner: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=3D4671249405c05bb65dfec261eb64= 5081ea72fdf5 >> >> commit 4671249405c05bb65dfec261eb645081ea72fdf5 >> Author: Matthias Fechner <mfechner@FreeBSD.org> >> <mfechner@FreeBSD.org> >> AuthorDate: 2022-06-30 14:28:33 +0000 >> Commit: Matthias Fechner <mfechner@FreeBSD.org> >> <mfechner@FreeBSD.org> >> CommitDate: 2022-06-30 14:32:13 +0000 >> >> net/rubygem-omniauth-auth0: Fix build failure > > >> Fixes a build regression after: >> 56e085ca55a831ab56e2e6b417bf230c827fd2e5 >> > > I think this commit is incorrect. > I could build this port successfully with rubygem-omniauth-oauth2 (1.8.0) > Please provide the error message. > > Furthermore, the only difference between omniauth-oauth2 1.7.3 and 1.8.0 > [1] is the change of omniauth from ">=3D1.9<3" to ">=3D2<3" > where security/rubygem-omniauth is 2.1.0 already. > I don't know how it can fix build failure. > > [1] https://github.com/omniauth/omniauth-oauth2/compare/v1.7.3...v1.8.0 > > And this change caused a race in the dependency tree. > > I suggest you build www/gitlab-ce, then you will see the error. > Or you can also search here to find the correct log file: > https://pkg.fechner.net/jail.html?mastername=3D131amd64-default > > Here the direct link to the log: > > https://pkg.fechner.net/build.html?mastername=3D131amd64-default&build=3D= 2022-06-30_10h05m29s > > Resolving dependencies... > Bundler could not find compatible versions for gem "omniauth": > In Gemfile: > omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depend= s on > omniauth (~> 1.0) > > omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depend= s on > omniauth-oauth2 (~> 1.4) was resolved to 1.8.0, which depends on > omniauth (~> 2.0) > *** Error code 6 > > This modification was the minimal fix I figured out without the need to > rollback a commit. > OK, the failure is about gitlab-ce but the commit message looks like it causes the build failure of net/rubygem-omniauth-auth0. Anyway, you could try this patch [1]. Then we could drop confusing net/rubygem-omniauth-oauth2-v1. [1] https://people.freebsd.org/~sunpoet/patch/gitlab-ce.txt > >> -RUN_DEPENDS=3D rubygem-omniauth-oauth2>=3D1.1:net/rubygem-omniauth-oa= uth2 >> > > That should be >=3D1.4<2 to match upstream (~> 1.4). > And net/rubygem-omniauth-oauth2 (1.8.0) fits the range. > > +RUN_DEPENDS=3D >> rubygem-omniauth-oauth2-v1>=3D1.4<2:net/rubygem-omniauth-oauth2-v1 >> >> yes and that is what I changed here. > > > Gru=C3=9F > Matthias > > -- > > "Programming today is a race between software engineers striving to > build bigger and better idiot-proof programs, and the universe trying to > produce bigger and better idiots. So far, the universe is winning." -- > Rich Cook > > --00000000000045e9fc05e38f369c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">On Wed, Jul 6, 2022 at 11:31 PM Matthias = Fechner <<a href=3D"mailto:mfechner@freebsd.org" target=3D"_blank">mfech= ner@freebsd.org</a>> wrote:<br></div><div class=3D"gmail_quote"><blockqu= ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px= solid rgb(204,204,204);padding-left:1ex"> =20 =20 =20 <div> <div>Dear Sunpoet,</div> <div><br> </div> <div>Am 06.07.2022 um 16:35 schrieb Po-Chuan Hsieh:<br> </div> <blockquote type=3D"cite"> =20 <div dir=3D"ltr"> <div dir=3D"ltr">On Thu, Jun 30, 2022 at 10:32 PM Matthias Fechner <<a href=3D"mailto:mfechner@freebsd.org" target=3D"_blank">mfe= chner@freebsd.org</a>> wrote:<br> </div> <div class=3D"gmail_quote"> <blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8= ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main= has been updated by mfechner:<br> <br> URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D467= 1249405c05bb65dfec261eb645081ea72fdf5" rel=3D"noreferrer" target=3D"_blank"= >https://cgit.FreeBSD.org/ports/commit/?id=3D4671249405c05bb65dfec261eb6450= 81ea72fdf5</a><br> <br> commit 4671249405c05bb65dfec261eb645081ea72fdf5<br> Author:=C2=A0 =C2=A0 =C2=A0Matthias Fechner <a href=3D"mailto:m= fechner@FreeBSD.org" target=3D"_blank"><mfechner@FreeBSD.org></a><br> AuthorDate: 2022-06-30 14:28:33 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Matthias Fechner <a href=3D"mailto:m= fechner@FreeBSD.org" target=3D"_blank"><mfechner@FreeBSD.org></a><br> CommitDate: 2022-06-30 14:32:13 +0000<br> <br> =C2=A0 =C2=A0 net/rubygem-omniauth-auth0: Fix build failure</bl= ockquote> <blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8= ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> =C2=A0 =C2=A0 Fixes a build regression after:<br> =C2=A0 =C2=A0 56e085ca55a831ab56e2e6b417bf230c827fd2e5<br> </blockquote> <div><br> </div> <div>I think this commit is incorrect.</div> <div>I could build this port successfully=C2=A0with=C2=A0rubygem-omniauth-oauth2 (1.8.0)</di= v> <div>Please provide the error=C2=A0message.</div> <div><br> </div> <div> <div>Furthermore, the only difference between omniauth-oauth2 1.7.3 and 1.8.0 [1] is the change of=C2=A0omniauth from ">=3D1.9<3" to "&g= t;=3D2<3" where=C2=A0security/rubygem-omniauth is 2.1.0 already.</div> <div>I don't know how it can fix build failure.</div> <div><br> </div> <div>[1]=C2=A0<a href=3D"https://github.com/omniauth/omniauth-o= auth2/compare/v1.7.3...v1.8.0" target=3D"_blank">https://github.com/omniaut= h/omniauth-oauth2/compare/v1.7.3...v1.8.0</a></div> </div> </div> </div> </blockquote> <p>And this change caused a race in the dependency tree.<br> </p> <p>I suggest you build www/gitlab-ce, then you will see the error.<br> Or you can also search here to find the correct log file:<br> <a href=3D"https://pkg.fechner.net/jail.html?mastername=3D131amd64-de= fault" target=3D"_blank">https://pkg.fechner.net/jail.html?mastername=3D131= amd64-default</a></p> <p>Here the direct link to the log:<br> <a href=3D"https://pkg.fechner.net/build.html?mastername=3D131amd64-default= &build=3D2022-06-30_10h05m29s" target=3D"_blank">https://pkg.fechner.ne= t/build.html?mastername=3D131amd64-default&build=3D2022-06-30_10h05m29s= </a></p> <pre>Resolving dependencies... Bundler could not find compatible versions for gem "omniauth": In Gemfile: omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depen= ds on omniauth (~> 1.0) omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depen= ds on omniauth-oauth2 (~> 1.4) was resolved to 1.8.0, which depends on omniauth (~> 2.0) *** Error code 6</pre> <p>This modification was the minimal fix I figured out without the need to rollback a commit.<br></p></div></blockquote><div><br></div><= div>OK, the failure is about gitlab-ce but the commit message looks like it= causes the build failure of net/rubygem-omniauth-auth0.</div><div><br></di= v><div>Anyway, you could try this patch [1]. Then we could drop confusing= =C2=A0net/rubygem-omniauth-oauth2-v1.</div><div><br></div><div>[1]=C2=A0<a = href=3D"https://people.freebsd.org/~sunpoet/patch/gitlab-ce.txt">https://pe= ople.freebsd.org/~sunpoet/patch/gitlab-ce.txt</a></div><div><br></div><bloc= kquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:= 1px solid rgb(204,204,204);padding-left:1ex"><div><p> </p> <blockquote type=3D"cite"> <div dir=3D"ltr"> <div class=3D"gmail_quote"> <div><br> </div> <blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8= ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> -RUN_DEPENDS=3D=C2=A0 =C2=A0rubygem-omniauth-oauth2>=3D1.1:net/rubygem-omniauth-oa= uth2<br> </blockquote> <div><br> </div> <div>That should be >=3D1.4<2 to match upstream (~> 1.4).</div> <div>And net/rubygem-omniauth-oauth2 (1.8.0) fits the range.</div= > <div><br> </div> <blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8= ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> +RUN_DEPENDS=3D=C2=A0 =C2=A0rubygem-omniauth-oauth2-v1>=3D1.4<2:net/rubygem-omn= iauth-oauth2-v1<br> <br> </blockquote> </div> </div> </blockquote> <p>yes and that is what I changed here.<br> </p> <p><br> </p> <pre cols=3D"72">Gru=C3=9F Matthias --=20 "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook </pre> </div> </blockquote></div></div> --00000000000045e9fc05e38f369c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58TnfW0H4X_iKseaa-y1M68q0Ea0XXNKUtngBS0fNvAiZw>