From owner-p4-projects@FreeBSD.ORG Wed Aug 25 21:15:35 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 101C710656A8; Wed, 25 Aug 2010 21:15:35 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C692410656A3; Wed, 25 Aug 2010 21:15:34 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 292AB8FC13; Wed, 25 Aug 2010 21:15:33 +0000 (UTC) Received: by ewy4 with SMTP id 4so666433ewy.13 for ; Wed, 25 Aug 2010 14:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=I2gpf82RGSLbJQQe6PXzk09cCC8dN6GX/2iYwSswQHI=; b=VsgNwLhSsl/lyiqF4N+zQtjaz9lS1sGSrYxy0ppnieXYH67FzR/6Y368+G3hkp4diO ncMaJHdaoh1rUGN5uw6yh+EhA9pG5Fukdl71PDDbj6QD3AlP+PEKvQzrfsw/wLXpgceH yp4kHlvCCsQ5A4Uu5BBH05Zld0I2un2a2fVTA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=ZFpLGhfypqtA+hb64EXApYfoN8aOTkl0FFaP8e+58ihAS2c37oaFaB1sdErVZCrcya oT3QDs6ATULSva+MoMqnyvSNeQ+1fYlqJ3qKqp4CwXY0E7SrPo7sApJ/gfjxEgWVrhw8 cYPwWglMmBcurMtYX0XMWpra2pLhy1jQoQToM= MIME-Version: 1.0 Received: by 10.213.80.140 with SMTP id t12mr5976132ebk.27.1282770932631; Wed, 25 Aug 2010 14:15:32 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.14.47.197 with HTTP; Wed, 25 Aug 2010 14:15:32 -0700 (PDT) In-Reply-To: <201008252114.05428.hselasky@freebsd.org> References: <201008251649.o7PGnD8q074706@skunkworks.freebsd.org> <201008252114.05428.hselasky@freebsd.org> Date: Wed, 25 Aug 2010 14:15:32 -0700 X-Google-Sender-Auth: cmPxzBuVmQqRkAYqrDnSEk6rqlo Message-ID: From: Garrett Cooper To: Hans Petter Selasky Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Perforce Change Reviews Subject: Re: PERFORCE change 182898 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2010 21:15:35 -0000 On Wed, Aug 25, 2010 at 12:14 PM, Hans Petter Selasky wrote: > On Wednesday 25 August 2010 20:21:25 Garrett Cooper wrote: >> On Wed, Aug 25, 2010 at 9:49 AM, Hans Petter Selasky >> >> wrote: >> > http://p4web.freebsd.org/@@182898?ac=3D10 >> > >> > Change 182898 by hselasky@hselasky_laptop001 on 2010/08/25 16:49:00 >> > >> > =A0 =A0 =A0 =A0LibUSB: >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0- patch for GNU/kFreeBSD by David Moles >> > >> > =A0 =A0 =A0 =A0PR: >> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D594330 Reviewed by: >> > =A0hselasky @ >> > >> > Affected files ... >> > >> > .. //depot/projects/usb/src/lib/libusb/libusb20.c#19 edit >> > >> > Differences ... >> > >> > =3D=3D=3D=3D //depot/projects/usb/src/lib/libusb/libusb20.c#19 (text+k= o) =3D=3D=3D=3D >> > >> > @@ -1182,7 +1182,7 @@ >> > =A0{ >> > =A0 =A0 =A0 =A0struct libusb20_backend *pbe; >> > >> > -#ifdef __FreeBSD__ >> > +#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) >> > =A0 =A0 =A0 =A0pbe =3D libusb20_be_alloc(&libusb20_ugen20_backend); >> > =A0#else >> > =A0 =A0 =A0 =A0pbe =3D NULL; >> >> Crazy question... if GNU/kFreeBSD is going to be rebranding the kernel >> as __FreeBSD_kernel__, what about the rest of the references that are >> guarded by __FreeBSD__ ? >> Thanks, >> -Garrett > > This check is not for checking if we are compiling in the kernel or not. = It is > only to check if we have a FreeBSD system kernel or not when compiling in > userspace. Fortunately LibUSB only has one of these checks. > > Was that your question? That answered my question I suppose. It's just kind of interesting how things are relatively mix and match with the GNU/*BSD hybrid OSes out there. Thanks! -Garrett