From owner-svn-src-all@freebsd.org Thu Feb 21 18:19:25 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C400014EAE60; Thu, 21 Feb 2019 18:19:24 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yw1-xc44.google.com (mail-yw1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3AC7C86824; Thu, 21 Feb 2019 18:19:24 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-yw1-xc44.google.com with SMTP id v201so11187167ywa.9; Thu, 21 Feb 2019 10:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=47HT63DqvmMUTgwX3oytIzlZ3JsNYzxfMzmmyv4hxz0=; b=FyIUyIe2sb9YCoEH64HEA2Badt7G2n9+kkGEzuR9u9wVeR9NJEpB30OEsGLj/iiWnG i/PYDq9lDeFHY5o5c9DQc7Le0JLZ4nhS2xfFFNjQkEb0hnzgA1U3X7jUnQdpwzShd+jy ee3fZX3ZoC+hFP6j8zmpTzrsDsDxbXgO/PUIMRP8foxxLuoY9rfbiQ3ipz0u6eZ7k8da /A//ar0Q4oCNLVzA7sU25q28cbjAf9QDP6aX/X+UZ/6YXHliR/tkiaGVdPGz1XaPcOPS OVBnbjZSyQqW02Z4E1at4Q2LpLFPCOF4XrA9Mf2LMslT2BOptD2hvV5Edpa9dLSyFGfL WYBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=47HT63DqvmMUTgwX3oytIzlZ3JsNYzxfMzmmyv4hxz0=; b=ltD4HJV3sBH7GfQojRgZ/Bj/4JfqANRwCCfz2J+cVLWcjfLaxcjKeHhqwTyKJOyO7t EC+HV4rCcRz4XJMKn9Y4KhNgja/+IGEAKA2uBway+FIW7ZnqdYhGpW5rQ6s6V2iecvAs G7SRXGQZ8JGQUkYyuygP6eTA6Q7015ybU19c5yWy9V62X3Kkxr3MGzjTqi6/BHFSoqvr gdq9NRWgtBpFkasIwygR1E1YNO2aWAaRub/DaRHpG9yMP77rUmZfJtzIWp1/fERHzMQL Z4gzTa9rXebB7JjTN/u9CxOqTDurZP8BY1Xbq33hAA+D/gWHcASLH24Iw9s+sDnNakzn FnCg== X-Gm-Message-State: AHQUAuaReDJr2uezQEJ4N5oYphj1rQOpgub+xTNZUmL4SMhO89xqXgBK GemZhEHEw54QTfd5/6zvON0z4gpD X-Google-Smtp-Source: AHgI3Ib1hzK96KC+5An9WEzbDnO5+B9UHTMc0/jWRQMsm+mtrBHi2gvJpPfJMvGKgz6dhHuV3nPFxA== X-Received: by 2002:a81:3c47:: with SMTP id j68mr34279275ywa.69.1550773163082; Thu, 21 Feb 2019 10:19:23 -0800 (PST) Received: from mavoffice.ixsystems.com ([12.189.233.129]) by smtp.gmail.com with ESMTPSA id a190sm8627620ywg.76.2019.02.21.10.19.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Feb 2019 10:19:22 -0800 (PST) Sender: Alexander Motin Subject: Re: svn commit: r344437 - head/sys/dev/ntb/ntb_hw To: Enji Cooper Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201902211410.x1LEAEa2042271@repo.freebsd.org> <8FC17E30-1360-44CE-9284-286B6282C244@gmail.com> From: Alexander Motin Openpgp: preference=signencrypt Autocrypt: addr=mav@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFOzxAwBCADkPrax0pI2W/ig0CK9nRJJwsHitAGEZ2HZiFEuti+6/4UVxj81yr4ak/4g 9bKUyC7rMEAp/ZHNhd+MFCPAAcHPvtovnfykqE/vuosCS3wlSLloix2iKVLks0CwbLHGAyne 46lTQW74Xl/33c3W1Z6d8jD9gVFT/xaVzZ0U9xdzOmsYAZaAj4ki0tuxO9F7L+ct9grRe7iP g8t9hai7BL4ee3VRwk2JXnKb7UvBiVITKYWKz1jRvZIrjPokgEcCLOSlv7x/1kjuFnj3xWZU 7HSFFT8J93epBbrSSCsYsppIk2fZH41kaaFXsMQfTPH8wkeM6qwrvOh4HiQM08R+9tThABEB AAHNIUFsZXhhbmRlciBNb3RpbiA8bWF2QEZyZWVCU0Qub3JnPsLAlwQTAQoAQQIbAwULCQgH AwUVCgkICwUWAwIBAAIeAQIXgAIZARYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMKuBQkN McyiAAoJEIMYw5VbqyJ/tuUIAOG3ONOSNYqjK4eTZ1TVh9jdUBAhWk5nhDFnODN49Wj0AbYm 7aIqy8O1hnCDSZG5LttjSAo3UfXJZDKQM0BLb0gpRMBnAYqO6tdolLNqAbPGJBnGoPjsh24y 6KcbDaNnis+lD4GwPXwQM+92wZGhCUFElPV9NciZGVS65TNIgk7X+yEjjhD1MSWKKijZ1r9Z zIt4OzUTxxNOvzdlABZS88nNRdJkatOQJPmFdd1mpP6UzTNCiLUo1pIqOEtJgvVVDYq5WHY6 tciWWYdmZG/tIBexJmv2mV2OLVjXR6ZeKmntVH14H72/wRHJuYHQC+r5SVRcWWayrThsY6jZ Yr4+raTOwE0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6Z AXgDtmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8Flv mI/c40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt 3ytU8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZ R1EdEIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm5 9R8AEQEAAcLAZQQYAQoADwUCU7PEDAIbDAUJBaOagAAKCRCDGMOVW6sif7FRB/4k9y/GaGqU fcJiXdQHRAKHCUvbKMFgeEDHOg33qx+POS2Ah85/PXVa2jYBldCZDmYc+zl48aEMd163a7s3 0gJaB7CYElwxlKUk6c+5gwoYIJuJJzSzW0JzSD5ch7RIRxbfxrKdsiHrUW8AeduZWzlK6VaW RmWILgLmxfLdhEVFWxbr99GSeVFZaZwn6tl/8CvBcgYoARvJvl0V5zS1akQfEISYkwL9EfUI W44EOHranL5qUXkedXBYp6fRsooGrIimfwYxaC8FbXhk3FMgMjDMRiVq4POHo1iGeYETsUrL NM6184E25gPVtX2fb3RhM8Xh6BkwCZ6ZYbQ+AcD4F/cKwsB8BBgBCgAmAhsMFiEE6YzzxOac w80OV51VgxjDlVurIn8FAllgwtgFCQ0xzMwACgkQgxjDlVurIn9OqAf9FAcKWS95wTTbraXA qg/+bQyHgjlMtGCgkmfxLsbUGeqiFgmSIuoDrF7q6sYPs6p00CXXZRuuNZt0lX7O95re8mgz gxm5iJisZpdbHMVepYlw/AxT2wCHwxGCEe64Lm+A9vjlOd+3D3/6fSLwZ9WFCE6p6lQZ1CDg 09xe+JKSgC+KDqmn0tzGKyfSCuhRAq3XkZyxL1hxBaDeP0eeKlzoy7jXodf3wVvXXc0cmpza B5McuRHK4EU6jIioHo30YqPM4AjPHGxV2X1N6/Aayungzj9EXNZtKCxs6dsTvjniWa5VkZ9F 4SOdSbxEen1DZRYpeWnd7GVmO86n+5USkKCXPg== Message-ID: <54cb17e7-9b4a-e779-22b6-0bf317bd86ca@FreeBSD.org> Date: Thu, 21 Feb 2019 13:19:21 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <8FC17E30-1360-44CE-9284-286B6282C244@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3AC7C86824 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.944,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2019 18:19:25 -0000 On 21.02.2019 13:13, Enji Cooper wrote: > >> On Feb 21, 2019, at 6:10 AM, Alexander Motin wrote: >> >> Author: mav >> Date: Thu Feb 21 14:10:14 2019 >> New Revision: 344437 >> URL: https://svnweb.freebsd.org/changeset/base/344437 >> >> Log: >> Allow I/OAT of present Xeon E5/E7 to work thorugh PLX NTB. >> >> Its a hack, we can't know/list all DMA engines, but this covers all >> I/OAT of Xeon E5/E7 at least from Sandy Bridge till Skylake I saw. >> >> MFC after: 1 week >> Sponsored by: iXsystems, Inc. >> >> Modified: >> head/sys/dev/ntb/ntb_hw/ntb_hw_plx.c >> >> Modified: head/sys/dev/ntb/ntb_hw/ntb_hw_plx.c >> ============================================================================== >> --- head/sys/dev/ntb/ntb_hw/ntb_hw_plx.c Thu Feb 21 12:13:27 2019 (r344436) >> +++ head/sys/dev/ntb/ntb_hw/ntb_hw_plx.c Thu Feb 21 14:10:14 2019 (r344437) >> @@ -202,16 +202,24 @@ ntb_plx_init(device_t dev) >> if (sc->alut) >> PNTX_WRITE(sc, 0xc94, 0); >> >> - /* Enable Link Interface LUT entries 0/1 for peer 0/1. */ >> - PNTX_WRITE(sc, 0xdb4, 0x00090001); >> + /* Enable all Link Interface LUT entries for peer. */ >> + for (i = 0; i < 32; i += 2) { > > Is `32` written down in the NTB spec somewhere? Should it be a #define, or should it be programmatically adjusted based on the CPU? It is a property of the hardware, it has 32 LUT entries. #define would be good indeed, but the code is already full of other numeric constants. -- Alexander Motin