Date: Sat, 14 Dec 2013 02:23:08 +0100 From: Luigi Rizzo <rizzo@iet.unipi.it> To: Mike Karels <mike@karels.net> Cc: Jack F Vogel <jfv@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, "net@freebsd.org" <net@freebsd.org> Subject: Re: IFF_DRV_OACTIVE handling in *_stop() for intel nic drivers ? Message-ID: <20131214012308.GB82745@onelab2.iet.unipi.it> In-Reply-To: <201312140008.rBE08tnO062920@mail.karels.net> References: <CAJ-Vmom8u9mw9h-Eq5EKvcwcpMKjNzdxcwVJLtg_jRfA0DWYxg@mail.gmail.com> <201312140008.rBE08tnO062920@mail.karels.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 13, 2013 at 06:08:55PM -0600, Mike Karels wrote: > > ... OACTIVE by design is racy. We should just not be using it in newer drivers. > > > I think the correct thing to do is to just plain ignore setting it ever. > > I agree; OACTIVE is totally obsolete for drivers that use if_transmit, > and not particularly useful for other drivers. It might be time to remove > OACTIVE, or define it to be 0. (And I added the original IFF_OACTIVE). ok thanks for the clarification luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131214012308.GB82745>