From owner-svn-src-all@freebsd.org Thu Jun 9 14:09:08 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67B7EB70BDF for ; Thu, 9 Jun 2016 14:09:08 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22f.google.com (mail-it0-x22f.google.com [IPv6:2607:f8b0:4001:c0b::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2F8E91C1A for ; Thu, 9 Jun 2016 14:09:08 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22f.google.com with SMTP id h190so35753106ith.1 for ; Thu, 09 Jun 2016 07:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=mDgJYi7Ua4Rj4WmP/PG5QFn+efq97JtCOSLqsmUGuyA=; b=YX5gwIq5DJbaQdl0mlTv/SuPggZEljxVw5zjmcFshjZVsMDzx4NOx33hWFtrLIu4WW VBMygCCLZNs4iLuokNQuB+szwrPrj5f/dROQCzoVhKuE/TR3rvi8OijLLXGcQ11cWRDa sW/AsL0UVgkiBvt2HMcTT4KmFHDkkoqCJonnBODyNbGSngHsbcHgA65tna9GkfJ3h/lN RgvX0Km2uVvixSZBKoJ9q6dvJgIIcxvUyhL18WQPsiNdMlk8D1SGDT2rm0FKyhxXF712 oi1Lmx1a5Wn/S/on0F3t2iMNkf+Vf4PpUBRFIIwT3F0XJeWnTkzXMGbLDkg5lppNRD/Q qL6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=mDgJYi7Ua4Rj4WmP/PG5QFn+efq97JtCOSLqsmUGuyA=; b=XMg6ZAPl5a2dbMGZf5Vqs2KBoti7BbYLI2zD2Lj69NmSWCOe+YxQ4/SgH6hlC725Cr Lc8+GAs69/ZmLvSjifORf70CaV7vsYIjBwUmMTqlyb7yzVZ2xOblgGgv6qwa/66iv2hm bmQNrUcBlUzgMdc+I9/hPnpCzxDG9S5W14b7uoJIbMmiQ/aXlIY3IFbjJ9u3pRACt1bO fg1C27ujSuMS76DwzThC0pXcfMSGvIjsS/rjy8puS8sOdHNF8RY2oBQdBZW9Dmk2R5HJ hgmmD2iO+szCMqdnruYNbElxs7K9/aiDxsgLVneoYrefxJkWM43tevxC8RYlS+WWfhCV Hd5A== X-Gm-Message-State: ALyK8tIgBq8KBztLWPYrRCrrHhgwfUISmYU0WXjNbjMcnBKesl+n1IiDKMPxupMSVefpzA== X-Received: by 10.36.28.201 with SMTP id c192mr17224739itc.96.1465481347506; Thu, 09 Jun 2016 07:09:07 -0700 (PDT) Received: from [10.65.212.14] ([137.122.64.8]) by smtp.gmail.com with ESMTPSA id j137sm3255516ioe.18.2016.06.09.07.09.06 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Jun 2016 07:09:06 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r301714 - head/sys/boot/efi/libefi From: Warner Losh In-Reply-To: <20160609144304.05437ef3d7f2fe9cd26704ac@bidouilliste.com> Date: Thu, 9 Jun 2016 10:09:06 -0400 Cc: Emmanuel Vadot , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <012000B7-2E79-48BE-B0AB-6C0D39DF8EAA@bsdimp.com> References: <201606090202.u5922pwl024436@repo.freebsd.org> <90D3441D-D130-4D00-A12D-F4D3B81E606B@bsdimp.com> <20160609144304.05437ef3d7f2fe9cd26704ac@bidouilliste.com> To: Emmanuel Vadot X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 14:09:08 -0000 We already have debugging framework for boot1.efi which we could use = here? I=E2=80=99m working on setting / getting of UEFI variables with support = for UEFI=E2=80=99s bootmgr protocol. That=E2=80=99s going to need some = way to debug it because it=E2=80=99s kinda complex... Warner > On Jun 9, 2016, at 8:43 AM, Emmanuel Vadot = wrote: >=20 >=20 > I wanted to more verbose in case of the system don't have partition o > n disk (or the EFI implementation only support raw disks like U-Boot) > but this might be a bad way of doing saw, I didn't think about the > implication you're talking about. I'll try to figure a better way to = do > this. >=20 > On Wed, 8 Jun 2016 22:21:36 -0400 > Warner Losh wrote: >=20 >>=20 >>> On Jun 8, 2016, at 10:02 PM, Emmanuel Vadot = wrote: >>>=20 >>> Author: manu >>> Date: Thu Jun 9 02:02:50 2016 >>> New Revision: 301714 >>> URL: https://svnweb.freebsd.org/changeset/base/301714 >>>=20 >>> Log: >>> Print a message when the efi disk isn't a logical partition. >>=20 >> Why on earth would you do that? This will print a message, one per = full disk, and our systems have 36 disks in them? >> Please consider backing this out... >>=20 >> Warner >>=20 >>=20 >>> Approved by: andrew (mentor) >>> Differential Revision: https://reviews.freebsd.org/D6782 >>>=20 >>> Modified: >>> head/sys/boot/efi/libefi/efipart.c >>>=20 >>> Modified: head/sys/boot/efi/libefi/efipart.c >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/sys/boot/efi/libefi/efipart.c Thu Jun 9 01:50:43 2016 = (r301713) >>> +++ head/sys/boot/efi/libefi/efipart.c Thu Jun 9 02:02:50 2016 = (r301714) >>> @@ -119,8 +119,11 @@ efipart_init(void)=20 >>> (void**)&blkio); >>> if (EFI_ERROR(status)) >>> continue; >>> - if (!blkio->Media->LogicalPartition) >>> + if (!blkio->Media->LogicalPartition) { >>> + printf("%s%d isn't a logical partition, = skipping\n", >>> + efipart_dev.dv_name, n); >>> continue; >>> + } >>>=20 >>> /* >>> * If we come across a logical partition of subtype = CDROM >>>=20 >=20 >=20 > --=20 > Emmanuel Vadot