From nobody Fri Jan 19 17:17:30 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TGmWt3Cbdz56xG4; Fri, 19 Jan 2024 17:17:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TGmWt1yFLz4MhZ; Fri, 19 Jan 2024 17:17:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705684650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gWv+ETUgaM0uO9670yi43/52MTphKD6lIBB+g+q60TY=; b=Z5VkmCLm4mmvoImB96Fc7DfyREU46ABavTq7otg0v+rXdaDRiM3gR1+gURHTAa3A/3BLKL wi29zV3Cm3B0gt5ceE8rL8WvT8gkprkXm1zRp+1B/0DTu7dv0eAAqpj5eqs7/14oj5gjIS YhGnc9Z5K17WG5xGWBEs1MQYMj04r9CDCIXWXWlxsE0aFj7NQzIkRFjvY6HtI/qlbtKYym nrqzqy+C3kVL+i8WE4Vw+5XXH+LZpFK1l0zkF5bm3QG07idcG11vN55Zcbp8Y9ei6ihbZa D5pGPuyHXKyO59HksViOID1zM8bnrLOsXErG81IH4+Nd1NHqSDtpj4NoPGLPYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705684650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gWv+ETUgaM0uO9670yi43/52MTphKD6lIBB+g+q60TY=; b=fxbL/dulJzqGFsvcLrOnH3LWSjMmhyGttDkVdltZDyx84koVQV4xsPL1RTrrbaWUgT/bgW eyMEYAJtVFWv5D5fZzx8ReOsi8kg97QDw7p8yz+i8aST7AV2yCcKsMyV0Vo5IRa9F8uCWf XTBPCQc/4M+2zpNOFLr7HmD3s5UFHRbjXzGEBiQmjpbn8dRu0/PdLrs7QX1+AkUey2oMJM ApsPNulVdMhckkgm4g0FC9jj048yV2rJ3JZuCFSPD6fp1B/Jke11A1Y762qYEKxg4vs2Qe 2lHtl78JJl9PymomTtUtK4UD/E2zADP4uchBXYkmNafXLTVxiHHYdcMXiipOhg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705684650; a=rsa-sha256; cv=none; b=W97z9B8Ud4DiRiVxjwIWT9wP54khMF7K8fTtRbmlPpkzH1ctF7ObX7ICaZYH6kcj9q22EE GWBlAMclOJoA+1GOLu/ps7Meh8dZnextZ61/I0ofeosBRcIpuAqZD0EYKrc5yBXwxGMVGe 73Syv/7RO7XGsXsghysiKFaJVORExqqyF76Sd4juCQft4OcbWs/wL07FzWG2do4BPtGw8o hwoDv+pWdRfg6bLryWC4jCqsKiLQ3xeuPxRlEs6jwEscD4T+j25WcJwjOQnnjms0GWSP6f N0PRgqcodCIwJ/3tISx57ojuWPYNShkEE++LJJPSGS3sDIIqmCB3wSgyEa+x/w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TGmWt11sTz10P1; Fri, 19 Jan 2024 17:17:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40JHHUKq096805; Fri, 19 Jan 2024 17:17:30 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40JHHUIw096802; Fri, 19 Jan 2024 17:17:30 GMT (envelope-from git) Date: Fri, 19 Jan 2024 17:17:30 GMT Message-Id: <202401191717.40JHHUIw096802@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alexander Motin Subject: git: e82c6e941e6a - stable/14 - mpi3mr: Remove unused fields in struct mpi3mr_cmd List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mav X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: e82c6e941e6a9ca34ad493018bcd43257bb08061 Auto-Submitted: auto-generated The branch stable/14 has been updated by mav: URL: https://cgit.FreeBSD.org/src/commit/?id=e82c6e941e6a9ca34ad493018bcd43257bb08061 commit e82c6e941e6a9ca34ad493018bcd43257bb08061 Author: Warner Losh AuthorDate: 2023-11-29 01:49:01 +0000 Commit: Alexander Motin CommitDate: 2024-01-19 17:16:49 +0000 mpi3mr: Remove unused fields in struct mpi3mr_cmd All of these fields are either unused, or just initialized. Remove them. This saves about 1MB of memory for the cards that I have which can do 8k transactions at once. Sponsored by: Netflix Reviewed by: mav, jhb Differential Revision: https://reviews.freebsd.org/D42538 (cherry picked from commit a2b046620c54db977196128b3c53da2704b9fd20) --- sys/dev/mpi3mr/mpi3mr.c | 3 --- sys/dev/mpi3mr/mpi3mr.h | 6 ------ 2 files changed, 9 deletions(-) diff --git a/sys/dev/mpi3mr/mpi3mr.c b/sys/dev/mpi3mr/mpi3mr.c index 592b0f02cdd7..7bb834430dbc 100644 --- a/sys/dev/mpi3mr/mpi3mr.c +++ b/sys/dev/mpi3mr/mpi3mr.c @@ -4986,12 +4986,9 @@ mpi3mr_get_command(struct mpi3mr_softc *sc) cmd->data_dir = 0; cmd->ccb = NULL; cmd->targ = NULL; - cmd->max_segs = 0; - cmd->lun = 0; cmd->state = MPI3MR_CMD_STATE_BUSY; cmd->data = NULL; cmd->length = 0; - cmd->out_len = 0; out: mtx_unlock(&sc->cmd_pool_lock); return cmd; diff --git a/sys/dev/mpi3mr/mpi3mr.h b/sys/dev/mpi3mr/mpi3mr.h index 1dc680beb47e..2226c747d3cf 100644 --- a/sys/dev/mpi3mr/mpi3mr.h +++ b/sys/dev/mpi3mr/mpi3mr.h @@ -457,19 +457,13 @@ struct mpi3mr_cmd { union ccb *ccb; void *data; u_int length; - u_int out_len; - struct uio uio; - struct iovec iovec[MPI3MR_IOVEC_COUNT]; - u_int max_segs; struct mpi3mr_target *targ; - u_int lun; u_int data_dir; u_int state; bus_dmamap_t dmamap; struct scsi_sense_data *sense; struct callout callout; bool callout_owner; - mpi3mr_cmd_callback_t *timeout_handler; U16 hosttag; U8 req_qidx; Mpi3SCSIIORequest_t io_request;