From owner-freebsd-current Sun Mar 2 4:53:19 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5323237B401 for ; Sun, 2 Mar 2003 04:53:17 -0800 (PST) Received: from mail.liwing.de (mail.liwing.de [213.70.188.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 738BF43FBF for ; Sun, 2 Mar 2003 04:53:15 -0800 (PST) (envelope-from rehsack@liwing.de) Received: (qmail 91454 invoked from network); 2 Mar 2003 12:53:13 -0000 Received: from stingray.liwing.de (HELO liwing.de) ([213.70.188.164]) (envelope-sender ) by mail.liwing.de (qmail-ldap-1.03) with SMTP for ; 2 Mar 2003 12:53:13 -0000 Message-ID: <3E61FEB9.2020102@liwing.de> Date: Sun, 02 Mar 2003 13:53:13 +0100 From: Jens Rehsack Organization: LiWing IT-Services User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.2) Gecko/20021120 Netscape/7.01 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Dag-Erling Smorgrav Cc: Juli Mallett , current@freebsd.org Subject: Re: PATCH: type errors in src-tree References: <3E5EA13E.9020208@liwing.de> <3E60F1CF.2030400@liwing.de> <20030301155546.A39174@FreeBSD.org> <3E612F7F.1090002@liwing.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Dag-Erling Smorgrav wrote: > Jens Rehsack writes: > >>Of course. Very often in ilmid.c the type caddr_t was used, and nearly >>the same count of 'const char *'s was used. I've searched the include >>files for caddr_t (core address) and found it defined as 'char *', so >>I decided to used commonly caddr_t - maybe later I check which of them >>could be changed into 'c_caddr_t' for being const. But You can of >>couse replace all 'caddr_t' which 'char *'. > > > This is wrong. caddr_t should be uniersally replaced with void *. Good to know. I think I have done it where it's possible, and where really (unsigned) char *(*) was required, I've used that. There're some places in code where I'm not sure about it's being correct, but that has nothing to do with char */void *. > DES Jens To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message