From owner-svn-src-all@FreeBSD.ORG Sat Jun 16 09:42:42 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 21094106564A; Sat, 16 Jun 2012 09:42:42 +0000 (UTC) (envelope-from tijl@coosemans.org) Received: from mailrelay012.isp.belgacom.be (mailrelay012.isp.belgacom.be [195.238.6.179]) by mx1.freebsd.org (Postfix) with ESMTP id 1000B8FC0A; Sat, 16 Jun 2012 09:42:40 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgAFAIlU3E9bsTjL/2dsb2JhbABFhVeve4EIghgBAQUjMyIBEAsOBgQCAgUWCwICCQMCAQIBJx4GDQEHAQEFiAYHpiqSQIEgihiFKYESA55IhlmCYg Received: from 203.56-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.56.203]) by relay.skynet.be with ESMTP; 16 Jun 2012 11:41:21 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.5/8.14.5) with ESMTP id q5G9fKGi011559; Sat, 16 Jun 2012 11:41:20 +0200 (CEST) (envelope-from tijl@coosemans.org) Message-ID: <4FDC54C0.3030105@coosemans.org> Date: Sat, 16 Jun 2012 11:41:20 +0200 From: Tijl Coosemans User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:13.0) Gecko/20120609 Thunderbird/13.0 MIME-Version: 1.0 To: Konstantin Belousov References: <201206122137.q5CLbReK077123@svn.freebsd.org> In-Reply-To: <201206122137.q5CLbReK077123@svn.freebsd.org> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r236976 - head/sbin/fsck_ffs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 09:42:42 -0000 On 12-06-2012 23:37, Konstantin Belousov wrote: > Author: kib > Date: Tue Jun 12 21:37:27 2012 > New Revision: 236976 > URL: http://svn.freebsd.org/changeset/base/236976 > > Log: > For incompleted block allocations or frees, the inode block count usage > must be recalculated. The blk_check pass of suj checker explicitely marks > inodes which owned such blocks as needing block count adjustment. But > ino_adjblks() is only called by cg_trunc pass, which is performed before > blk_check. As result, the block use count for such inodes is left wrong. > This causes full fsck run after journaled run to still find inconsistencies > like 'INCORRECT BLOCK COUNT I=14557 (328 should be 0)' in phase 1. > > Fix this issue by running additional adj_blk pass after blk_check, which > updates the field. > > Reviewed by: jeff, mckusick > MFC after: 1 week Thanks! This probably fixes http://www.freebsd.org/cgi/query-pr.cgi?pr=165950