Date: Wed, 31 Oct 2018 07:48:08 -0400 From: Steve Wills <swills@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org>, Jan Beich <jbeich@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r483541 - in head/net-mgmt/prometheus2: . files Message-ID: <b1834077-b7da-8822-11e3-fde57939df58@FreeBSD.org> In-Reply-To: <20181031033142.GA782@FreeBSD.org> References: <201810310144.w9V1i4pO035552@repo.freebsd.org> <20181031015036.GA11773@FreeBSD.org> <8t2e-pzvc-wny@FreeBSD.org> <20181031033142.GA782@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On 10/30/18 11:31 PM, Alexey Dokuchaev wrote: > > I understand it's too late, I didn't ask for message amendment. My point > was that this information (perhaps in its concise form) should be included > in the commit log, so whoever reading the diff months/years later could do > that without Bugzilla access in order to understand the problem behind the > commit, how it was fixed, and why it was fixed the way it was. > I agree commit messages these days tend to be light on explanations of why things are done and it would be nice if they explained more the reasoning behind a commit in general. This one was complicated and I was tired and couldn't come up with a suitably short description that would still be useful, so I figured the PR reference would have to be sufficient. Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b1834077-b7da-8822-11e3-fde57939df58>